fix clang build with glibc 2.42 re: struct termio #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream LLVM recently gained support for building with glibc 2.42:
llvm/llvm-project@59978b2
llvm/llvm-project@c99b1bc
Backport these fixes to this project's vendored copy of clang. This
allows us to build Infer on Arch Linux, which recently upgraded its
glibc to 2.42:
https://gitlab.archlinux.org/archlinux/packaging/packages/glibc/-/commit/3543edc0a9e583f9c3880c197d83409c5e8d4020
etwoo
force-pushed
the
bugfix/backport-llvm-struct-termio-glibc-2.42
branch
from
2a0ddb8 to
0e4d6ce
Compare
Contributor
Author
|
Assuming the feedback from #1939 (comment) would also apply here, I've rebased this bugfix branch onto HEAD of main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit some issues building Infer from source in my Arch Linux dev environment. The problem seems to be specific to compiling against glibc 2.42, which Arch recently accepted into its official repositories.
The fix in this PR is to backport fixes from LLVM upstream for llvm/llvm-project#137321