Pass legacy hermes flag for HermesVariant.Hermes #54543
Closed
+14
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 14, 2025
Summary: Changelog: [Internal] We are switching to SH as default, so for the current default hermes variant, we need to pass the legacy hermes falg to continue using it. Differential Revision: D87082037
lavenzg
force-pushed
the
export-D87082037
branch
from
7d5812a to
ab71674
Compare
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 14, 2025
Summary: Changelog: [Internal] We are switching to SH as default, so for the current default hermes variant, we need to pass the legacy hermes falg to continue using it. Differential Revision: D87082037
lavenzg
force-pushed
the
export-D87082037
branch
from
ab71674 to
6ffc18c
Compare
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 15, 2025
…se SH internally (facebook#54543) Summary: Changelog: [Internal] We are switching to SH as default, so internally, we need to switch DEFAULT_HERMES_VARIANT to use SH stable. To keep the tests working in OSS, we add DEFAULT_OSS_HERMES_VARIANT to use legacy Hermes. Differential Revision: D87082037
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 17, 2025
…se SH internally (facebook#54543) Summary: Changelog: [Internal] We are switching to SH as default, so internally, we need to switch DEFAULT_HERMES_VARIANT to use SH stable. To keep the tests working in OSS, we add DEFAULT_OSS_HERMES_VARIANT to use legacy Hermes. Reviewed By: cipolleschi Differential Revision: D87082037
…se SH internally (facebook#54543) Summary: Changelog: [Internal] We are switching to SH as default, so internally, we need to switch DEFAULT_HERMES_VARIANT to use SH stable. To keep the tests working in OSS, we add DEFAULT_OSS_HERMES_VARIANT to use legacy Hermes. Reviewed By: cipolleschi Differential Revision: D87082037
lavenzg
force-pushed
the
export-D87082037
branch
from
6ffc18c to
0ebfa3e
Compare
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 17, 2025
…se SH internally (facebook#54543) Summary: Changelog: [Internal] We are switching to SH as default, so internally, we need to switch DEFAULT_HERMES_VARIANT to use SH stable. To keep the tests working in OSS, we add DEFAULT_OSS_HERMES_VARIANT to use legacy Hermes. Reviewed By: cipolleschi Differential Revision: D87082037
|
This pull request has been merged in 11f6ffd. |
Collaborator
|
This pull request was successfully merged by @lavenzg in 11f6ffd When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
We are switching to SH as default, so for the current default hermes
variant, we need to pass the legacy hermes falg to continue using it.
Differential Revision: D87082037