Skip to content

feat: Change SpillPartitionId::kMaxSpillLevel to 7 #15401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Change SpillPartitionId::kMaxSpillLevel to 7 #15401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions velox/exec/Spill.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ class ConcatFilesSpillMergeStream final : public SpillMergeStream {
class SpillPartitionId {
public:
/// Maximum spill level supported by 'SpillPartitionId'.
static constexpr uint32_t kMaxSpillLevel{3};
static constexpr uint32_t kMaxSpillLevel{7};

/// Maximum number of partition bits per spill level supported by
/// 'SpillPartitionId'.
Expand Down Expand Up @@ -329,7 +329,10 @@ class SpillPartitionId {
// (3 ~ 5 bits): Represents the partition number at the 2nd level.
// (6 ~ 8 bits): Represents the partition number at the 3rd level.
// (9 ~ 11 bits): Represents the partition number at the 4th level.
// (12 ~ 28 bits): Unused
// (12 ~ 14 bits): Represents the partition number at the 5th level.
// (15 ~ 17 bits): Represents the partition number at the 6th level.
// (18 ~ 20 bits): Represents the partition number at the 7th level.
// (21 ~ 28 bits): Unused
// (29 ~ 31 bits): Represents the current spill level.
// <MSB>
uint32_t encodedId_{kInvalidEncodedId};
Expand Down
Loading