refactor: Use const_iterator first #15438
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
beliefer
force-pushed
the
using_const_iterator_first
branch
from
e171ba7 to
e3bb010
Compare
beliefer
force-pushed
the
using_const_iterator_first
branch
from
e3bb010 to
609b7f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to use
const_iteratorfirst.When I read the source code, I want know whether the code modify the iterator.
cbeginandcendcould tell developers that the underlying code will not change the iterator. Butbeginandendnot tell me more. I must understand the function (e.g. std::sort) and know the fact.I think this PR could help Velox to improve the readability.