perf: Add Filter::testStringView #15441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When testing filters against in-memory `StringView` vectors, we observe suboptimal performance when using the `testBytes` interface. This is because `StringView` can compare the inline or prefix part in a few instructions before going into the byte-to-byte comparison loop, but `testBytes` does not use it. Leverage this by adding a `testStringView` interface. The gain is most significant for an equality filter with a small string (no longer than 12 bytes). Differential Revision: D85272787
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
xiaoxmeng
approved these changes
Nov 10, 2025
kagamiori
approved these changes
Nov 11, 2025
Contributor
kagamiori
left a comment
kagamiori
left a comment
There was a problem hiding this comment.
Do we also need to optimize MultiRange filter?
Contributor
Author
|
@kagamiori We definitely could, but the benefit is not as significant, and the chance of multi-range being push down is not high either. |
|
This pull request has been merged in 85f6926. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When testing filters against in-memory
StringViewvectors, we observe suboptimal performance when using thetestBytesinterface. This is becauseStringViewcan compare the inline or prefix part in a few instructions before going into the byte-to-byte comparison loop, buttestBytesdoes not use it. Leverage this by adding atestStringViewinterface. The gain is most significant for an equality filter with a small string (no longer than 12 bytes).Differential Revision: D85272787