Skip to content

Fix IDSelector handling in unbounded HNSW search - #5508

Open
YingzuoLiu wants to merge 2 commits into
facebookresearch:mainfrom
YingzuoLiu:fix/hnsw-unbounded-selector
Open

Fix IDSelector handling in unbounded HNSW search#5508
YingzuoLiu wants to merge 2 commits into
facebookresearch:mainfrom
YingzuoLiu:fix/hnsw-unbounded-selector

Conversation

@YingzuoLiu

Copy link
Copy Markdown

Summary

  • apply SearchParametersHNSW.sel to the unbounded HNSW search path
  • keep filtered nodes available for graph traversal while excluding them from the result set
  • add regression coverage for L2 and inner-product search, restrictive efSearch, and an empty selector

Root cause

The bounded HNSW path applies the selector through its result handler. The unbounded path did not receive the selector and used the same heap for traversal pruning and final results, so IDs rejected by SearchParameters.sel could be returned.

Implementation

When a selector is present, the unbounded path maintains a separate result heap containing only accepted IDs. The existing candidate heap remains unchanged and can still contain rejected nodes, preserving traversal through them. The selector-free path keeps its existing compile-time specialization and behavior.

Validation

  • issue reproducer: unbounded search now returns ID 1 at distance 100.0 instead of rejected ID 0
  • tests/test_search_params.py: 51 passed
  • HNSW C++ tests: 7 passed
  • full CPU C++ test suite: 273 passed, 5 skipped, 0 failed
  • clang-format and git diff --check: passed

Fixes #5504

@meta-cla

meta-cla Bot commented Aug 9, 2026

Copy link
Copy Markdown

Hi @YingzuoLiu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Aug 9, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Aug 9, 2026
@YingzuoLiu
YingzuoLiu marked this pull request as ready for review August 9, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IndexHNSW ignores SearchParameters.sel when bounded_queue=False

1 participant