Skip to content

Detect RISC-V RVV support from target flags - #5510

Open
KimmyXYC wants to merge 1 commit into
facebookresearch:mainfrom
KimmyXYC:fix/auto-detect-riscv-rvv
Open

Detect RISC-V RVV support from target flags#5510
KimmyXYC wants to merge 1 commit into
facebookresearch:mainfrom
KimmyXYC:fix/auto-detect-riscv-rvv

Conversation

@KimmyXYC

Copy link
Copy Markdown

Summary

  • Detect RVV and Zvfhmin support using the active compiler target flags.
  • Enable the RISC-V vector kernels only when the compiler probe succeeds.
  • Fall back to scalar implementations for lower RISC-V target baselines.
  • Remove per-source -march=rv64gcv_zvfhmin and -mabi=lp64d overrides.

Motivation

Faiss currently selects RVV kernels for every RISC-V target and forces a specific architecture through per-source compiler options. This can make binaries incompatible with lower target baselines and bypass distribution compiler flags.

Automatic detection keeps lower baselines portable while still enabling the RVV implementations when the selected target provides both RVV and Zvfhmin.

Testing

Tested through openRuyi OBS builds:

  • RVA20/RISC-V: the probe failed as expected, scalar implementations were used, and the build and checks succeeded.
  • RVA23/RISC-V: the probe succeeded, RVV sources were compiled, and the build and checks succeeded.
  • AMD64: the RISC-V probe was skipped and the build and checks succeeded.

Signed-off-by: Kimmy <yucheng.or@isrc.iscas.ac.cn>
@meta-cla

meta-cla Bot commented Aug 11, 2026

Copy link
Copy Markdown

Hi @KimmyXYC!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Aug 11, 2026
@meta-cla

meta-cla Bot commented Aug 11, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant