feat(locale): add Japanese horse breed definitions#3718
Open
atzzCokeK wants to merge 4 commits intofaker-js:nextfrom
Open
feat(locale): add Japanese horse breed definitions#3718atzzCokeK wants to merge 4 commits intofaker-js:nextfrom
atzzCokeK wants to merge 4 commits intofaker-js:nextfrom
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3718 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 886 886
Lines 3062 3062
Branches 556 556
=======================================
Hits 3028 3028
Misses 30 30
Partials 4 4
🚀 New features to boost your workflow:
|
atzzCokeK
force-pushed
the
feat/ja-animal-horse
branch
from
0b12c21 to
0501f61
Compare
Resolve conflicts with upstream changes
Add characters: 与, 御, 曽, 那
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add horse breed definitions for the Japanese (ja) locale.
This enables
faker.animal.horse()to generate Japanese horse breed names.Added files
horse.ts - Horse breeds (30 items)
Japanese native horses (日本在来馬 - all 8 breeds)
Other breeds popular in Japan
References
Test plan
pnpm run generate:localesexecuted successfullypnpm run preflightpassed