feat(locale): add Japanese fish definitions#3721
feat(locale): add Japanese fish definitions#3721atzzCokeK wants to merge 2 commits intofaker-js:nextfrom
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3721 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 883 883
Lines 3061 3061
Branches 556 540 -16
=======================================
Hits 3027 3027
Misses 30 30
Partials 4 4
🚀 New features to boost your workflow:
|
|
Hi @atzzCokeK 👋 |
|
@xDivisionByZerox Yes, what you mentioned is perfectly right. I’ll do a final check on this PR and mark it as Ready for review soon. Thanks you🙏🏽 |
1255ad2 to
52b9854
Compare
T_EDITOR=true git -C /Users/atsushi.kawamura/.cursor/worktrees/faker/vmq add src/locales/ja/animal/index.ts && GIT_EDITOR=true git -C /Users/atsushi.kawamura/.cursor/worktrees/faker/vmq rebase --continue
fa07a6f
52b9854 to
fa07a6f
Compare
Summary
Add fish definitions for the Japanese (ja) locale.
Added files
fish.ts - Fish species (40 items)
Japanese freshwater fish
Aquarium fish
References
Test plan
pnpm run generate:localesexecuted successfully