Skip to content

feat(locale): add Japanese fish definitions#3721

Open
atzzCokeK wants to merge 2 commits intofaker-js:nextfrom
atzzCokeK:feat/ja-animal-fish
Open

feat(locale): add Japanese fish definitions#3721
atzzCokeK wants to merge 2 commits intofaker-js:nextfrom
atzzCokeK:feat/ja-animal-fish

Conversation

@atzzCokeK
Copy link
Contributor

Summary

Add fish definitions for the Japanese (ja) locale.

Added files

fish.ts - Fish species (40 items)

Japanese freshwater fish

金魚, 錦鯉, メダカ, ドジョウ, フナ, 鯉, アユ, ヤマメ, イワナ, etc.

Aquarium fish

グッピー, ネオンテトラ, エンゼルフィッシュ, ベタ, アロワナ, etc.

References

Test plan

  • pnpm run generate:locales executed successfully

@netlify
Copy link

netlify bot commented Jan 31, 2026

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fa07a6f
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/699fdb00d570bc00087f2ff9
😎 Deploy Preview https://deploy-preview-3721.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.88%. Comparing base (54af8a8) to head (fa07a6f).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3721   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         883      883           
  Lines        3061     3061           
  Branches      556      540   -16     
=======================================
  Hits         3027     3027           
  Misses         30       30           
  Partials        4        4           
Files with missing lines Coverage Δ
src/locales/ja/animal/index.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox
Copy link
Member

Hi @atzzCokeK 👋
I see that all you currently opened PRs are in draft. I assumed you did this to make us focus on one PR at the time, so we do not "bounce" between PRs and run into problems with the snapshot in an uncoordinated manner.
If that is the case, do we want to continue with this PR? Just mark your PR "Ready for review" if you approve with this process. The snapshot tests need an update and the locale file generation needs to be run again, as well.
We appreciate your support 🙏

@atzzCokeK
Copy link
Contributor Author

@xDivisionByZerox Yes, what you mentioned is perfectly right. I’ll do a final check on this PR and mark it as Ready for review soon. Thanks you🙏🏽

@atzzCokeK atzzCokeK force-pushed the feat/ja-animal-fish branch from 1255ad2 to 52b9854 Compare February 7, 2026 04:14
@atzzCokeK atzzCokeK marked this pull request as ready for review February 7, 2026 04:15
@atzzCokeK atzzCokeK requested a review from a team as a code owner February 7, 2026 04:15
matthewmayer
matthewmayer previously approved these changes Feb 7, 2026
Shinigami92
Shinigami92 previously approved these changes Feb 11, 2026
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: animal Something is referring to the animal module labels Feb 25, 2026
ST-DDT
ST-DDT previously approved these changes Feb 25, 2026
T_EDITOR=true git -C /Users/atsushi.kawamura/.cursor/worktrees/faker/vmq add src/locales/ja/animal/index.ts && GIT_EDITOR=true git -C /Users/atsushi.kawamura/.cursor/worktrees/faker/vmq rebase --continue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: animal Something is referring to the animal module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants