Repository navigation
Revert "Add support for unix domain sockets (#109)" - #111
Merged
Merged
Conversation
This reverts commit 90ece3b. Dropping a missing socket address from the result shifts every entry down by one, so @fastify/proxy-addr treats the last X-Forwarded-For entry as the socket address. Since 3.1.0, fastify's CI fails on test/trust-proxy.test.js ("trust proxy with number and null socket remoteAddress ignores forwarded headers"): request.ip is '1.1.1.1' instead of null. Reverting restores the behavior of 3.0.x and fixes fastify's CI. Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
Eomm
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 90ece3b.
Dropping a missing socket address from the result shifts every entry down by one, so @fastify/proxy-addr treats the last X-Forwarded-For entry as the socket address. Since 3.1.0, fastify's CI fails on test/trust-proxy.test.js ("trust proxy with number and null socket remoteAddress ignores forwarded headers"): request.ip is '1.1.1.1' instead of null. Reverting restores the behavior of 3.0.x and fixes fastify's CI.