-
Notifications
You must be signed in to change notification settings - Fork 412
New actor hierarchy #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New actor hierarchy #1652
Changes from all commits
a6f359d
b3d83ec
fa1e30e
52cc55f
1c31954
d250e5f
41d7c73
0afdd6f
cb3b6e8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -59,12 +59,7 @@ export function useAutoEnhance(tab: Extract<Tab, { type: "sessions" }>) { | |||||
|
|
||||||
| if (listenerJustStopped) { | ||||||
| startEnhance(); | ||||||
| } | ||||||
| }, [listenerStatus, prevListenerStatus, startEnhance]); | ||||||
|
|
||||||
| useEffect(() => { | ||||||
| if (enhanceTask.status === "generating" && tab.state.editor !== "enhanced") { | ||||||
| updateSessionTabState(tab, { editor: "enhanced" }); | ||||||
| } | ||||||
|
Comment on lines
60
to
63
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainVerify that setting editor state to "enhanced" before enhancement completes is intentional. The editor state is updated to "enhanced" immediately when the listener stops (line 62), but
Consider moving I'll examine the codebase to verify the review comment's concerns about the timing of the editor state update. Length of output: 2002 Move The review comment's concerns are valid:
The fix requires modifying the 🤖 Prompt for AI Agents |
||||||
| }, [enhanceTask.status, tab, updateSessionTabState]); | ||||||
| }, [listenerStatus, prevListenerStatus, startEnhance]); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add missing dependencies to the useEffect dependency array. The effect uses Apply this diff: - }, [listenerStatus, prevListenerStatus, startEnhance]);
+ }, [listenerStatus, prevListenerStatus, startEnhance, tab, updateSessionTabState]);📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid hard-coding a user-specific DB path
DBpoints at/Users/yujonglee/..., which will fail for everyone else. Please parameterize this (e.g. pick it up from env or default to$HOME/Library/...) or document how to override it before landing.🤖 Prompt for AI Agents