feat: 홈 화면 모바일 반응형 적용 (#184) - #185
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
Walkthrough홈 화면 전반에 모바일 반응형 레이아웃, 타이포그래피, 카드 및 캐러셀 스타일이 적용되었습니다. 약속 목록은 3개 기준의 펼치기/접기 상태와 접근성 속성을 사용하도록 변경되었으며, 책 빈 상태와 탭 간격도 조정되었습니다. Changes홈 모바일 반응형 개편
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant MyMeetingsSection
participant MeetingQuery
User->>MyMeetingsSection: 펼치기 클릭
MyMeetingsSection->>MyMeetingsSection: isExpanded 설정
MyMeetingsSection->>MeetingQuery: fetchNextPage()
MeetingQuery-->>MyMeetingsSection: 다음 약속 목록 반환
MyMeetingsSection-->>User: 전체 목록과 접기 버튼 표시
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/gatherings/components/GatheringCard.tsx`:
- Around line 69-73: Update the favorite button’s keyboard handling around
handleFavoriteClick so Enter and Space events are not propagated to the
GatheringCard root onKeyDown. Preserve the button’s native keyboard activation
and ensure card navigation does not trigger when the favorite button is focused.
In `@src/pages/Home/components/MyMeetingsSection.tsx`:
- Line 85: Update the my-meetings list container identified by id
"my-meetings-list" to preserve the existing max-h-98 height limit and
overflow-y-auto scrolling on desktop, while keeping those restrictions disabled
on mobile.
- Around line 32-37: Update handleExpand so expanding continues fetching pages
until hasNextPage is false, rather than invoking fetchNextPage only once.
Preserve setting isExpanded to true, and use the existing pagination state and
fetchNextPage flow without requiring the user to collapse and expand again.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 40ec3efb-c8a5-4fe1-81e5-a67c79259ad6
📒 Files selected for processing (10)
src/features/book/components/BookCarousel.tsxsrc/features/gatherings/components/GatheringCard.tsxsrc/pages/Home/HomePage.tsxsrc/pages/Home/components/FavoriteGatheringsSection.tsxsrc/pages/Home/components/HomeBookCard.tsxsrc/pages/Home/components/HomeMeetingCard.tsxsrc/pages/Home/components/HomeSectionHeader.tsxsrc/pages/Home/components/MyMeetingsSection.tsxsrc/pages/Home/components/ReadingBooksSection.tsxsrc/shared/ui/Tabs.tsx
haruyam15
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 풀 리퀘스트 제안
📋 작업 내용
홈 화면을 첨부된 모바일 시안의 데이터·빈 상태·약속 펼침 상태에 맞춰 반응형으로 구현했습니다.
🔧 변경 사항
📸 스크린샷
📄 기타
관련 이슈: closes #184
Summary by CodeRabbit
새로운 기능
개선 사항