Skip to content

Drop "In Both" from comparison - #140

Merged
yselkowitz merged 1 commit into
fedora-eln:masterfrom
yselkowitz:master
Oct 29, 2026
Merged

yselkowitz merged 1 commit into
fedora-eln:masterfrom
yselkowitz:master

Conversation

@yselkowitz

@yselkowitz yselkowitz commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Complete historical lists can already be viewed above this; the main point of comparison is to see what has changed, and including (the vast majority) what has not just makes this much longer than it needs to be.

Summary by CodeRabbit

  • Updates
    • Package comparisons now show only items unique to each selected date; packages present on both dates are no longer displayed.
    • The comparison row count now reflects the longer list of unique items, rather than including shared packages.

Complete historical lists can already be viewed above this; the main point
of comparison is to see what has changed, and including (the vast majority)
what has not just makes this much longer than it needs to be.
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5da3f766-ae33-4219-87cf-041bfc070494
Commits

Reviewing files that changed from the base of the PR and between bb11c86 and b5a1d92.

Files selected for processing: 1
  • templates/view_overview.html

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The overview comparison now lists only packages unique to Date A and Date B. It no longer computes or displays shared packages, and it sizes rows from the longer exclusive list.

Changes: Date comparison display

Layer / File(s) Summary
Exclusive comparison results
templates/view_overview.html
The template removes the shared-package calculation, table cell, and column header. The row count uses the longer of the Date A and Date B exclusive lists.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Possibly related PRs

Merge Risk: Minimal · up to b5a1d

The comparison change cleanly removes shared entries without an identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: removing the “In Both” comparison results.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@andrewnaessens andrewnaessens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes, all 4 references to inBoth have been removed. Changes look good.

@yselkowitz
yselkowitz requested a review from bhoy-troy October 29, 2026 10:52
@yselkowitz
yselkowitz merged commit 7b4a35e into fedora-eln:master Oct 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants