support plt and act by nuomi2021 · Pull Request #288 · ffvvc/FFmpeg

nuomi2021 · 2025-04-26T12:32:36Z

replace #224

@QSXW this is the refined version.
Please review and help upstream it after the SEI patch is merged.

QSXW · 2025-04-26T13:52:04Z

+
+    const int size = width * height;
+    for (int i = 0; i < size; i++) {
+        const int y0 = av_clip(y[i],  min, max);


There is an extra space before min.

fixed and change av_clip to av_clip_intp2

QSXW · 2025-04-26T14:00:13Z

    return ret;
 }

+static TransformUnit* palette_add_tu(VVCLocalContext *lc, const int start, const int end, const VVCTreeType tree_type)


The TransformUnit* need to be TransformUnit *

We use this style for all functions that return a pointer, such as add_tu. This means the function should return a TransformUnit pointer.

QSXW · 2025-04-26T14:02:54Z

+}
+
+static void palette_update_predictor(VVCLocalContext *lc, const bool local_dual_tree, int start, int end,
+    bool *predictor_reused, const int predictor_size)


Can we use bool?

yes. c99 has bool

QSXW · 2025-04-26T14:03:14Z

+        Palette *plt = cu->plt + c;
+        int i = cu->plt[start].size;;
+
+        //copy unused predictors to the end of plt


better to use // copy unused predictors to the end of plt

QSXW · 2025-04-26T14:06:47Z

+        const int hs       = sps->hshift[c];
+        const int vs       = sps->vshift[c];
+        uint8_t *u8        = (uint8_t*)tb->coeffs;
+        uint16_t *u16      = (uint16_t*)tb->coeffs;


(uint16_t*) to `(uint16_t *)

nuomi2021 · 2025-04-27T02:03:50Z

@QSXW thank you for the review. All fixed.

QSXW · 2025-04-27T12:00:25Z

  constrains
 - FFV1 parser
-
+- VVC decoder supports all content of SCC (Screen Content Coding):


I added this message to the part of version 7.1... Could you help move it below the version : And the signed off email is wrong, should be outlook.com

Oh, you can change this before you send it to upstream for review.

…void" This reverts commit 7684243 and a888975.

This allows catching IO errors occuring at file close. Signed-off-by: Marton Balint <cus@passwd.hu>

Signed-off-by: Marton Balint <cus@passwd.hu>

…rocess Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

Introduction at https://ieeexplore.ieee.org/document/9408666 passed files: 10b422_G_Sony_5.bit 10b422_H_Sony_5.bit 10b422_I_Sony_5.bit 10b422_J_Sony_5.bit 10b422_K_Sony_5.bit 10b422_L_Sony_5.bit 8b422_G_Sony_5.bit 8b422_H_Sony_5.bit 8b422_I_Sony_5.bit 8b422_J_Sony_5.bit 8b422_K_Sony_5.bit 8b422_L_Sony_5.bit 8b444_A_Kwai_2.bit 8b444_B_Kwai_2.bit PALETTE_A_Alibaba_2.bit PALETTE_B_Alibaba_2.bit PALETTE_C_Alibaba_2.bit PALETTE_D_Alibaba_2.bit PALETTE_E_Alibaba_2.bit Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

See 8.4.3 Derivation process for chroma intra prediction mode Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

…t cbcr residual functionality Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

See 8.7.4.6 Residual modification process for blocks using colour space conversion Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

See 8.7.3 Scaling process for transform coefficients Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

prepare for adaptive color transform Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

passed files: ACT_A_Kwai_3.bit ACT_B_Kwai_3.bit Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

nuomi2021 · 2025-05-17T07:38:52Z

merged as a65d028
Thank you, Jianhua and all

QSXW reviewed Apr 26, 2025

View reviewed changes

nuomi2021 force-pushed the plt branch from 287a4ed to 8242475 Compare April 27, 2025 01:56

QSXW reviewed Apr 27, 2025

View reviewed changes

cus and others added 24 commits May 16, 2025 20:43

Revert "fftools/textformat/avtextformat: Make close functions return …

a124c9a

…void" This reverts commit 7684243 and a888975.

fftools/textformat: correctly propagate uninit error codes

0d6ef6f

This allows catching IO errors occuring at file close. Signed-off-by: Marton Balint <cus@passwd.hu>

tests/fate/probe: add test for pcm misdetected as mp3 in wav

a6a510c

Signed-off-by: Marton Balint <cus@passwd.hu>

tests/fate/probe: add test for dts in wav

fe97bf8

Signed-off-by: Marton Balint <cus@passwd.hu>

avcodec/vvc/cabac: add 9.3.3.5 k-th order Exp - Golomb binarization p…

02fe29f

…rocess Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/cabac: add 9.3.3.7 Fixed-length binarization process

a7320ef

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/cabac: add palette support

89ba1bb

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc: add VVC_MAX_NUM_PALETTE_PREDICTOR_SIZE

d80041f

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/ctu: refact out ff_vvc_channel_range

cfea9b8

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc: refact out ep_init and ep_init_wpp

75e5fb6

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc: refact, save pf and ciip_flag in ff_vvc_set_intra_mvf

d0f9151

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/ctu: refact out intra_data

3ecf8f8

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/intra: add ff_vvc_palette_derive_scale

fd85f83

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/ctu: add palette support

26215b8

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/filter: skip deblocking filter for palette

95473fa

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/cabac: add ff_vvc_cu_act_enabled_flag

b9c5fb0

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/ctu: read act_enabled_flag for adaptive color transform

c58357e

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/ctu: fix derive_chroma_intra_pred_mode

d00a249

See 8.4.3 Derivation process for chroma intra prediction mode Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/dsp: update the interface of pred_residual_joint for join…

8bdad76

…t cbcr residual functionality Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/dsp: add adaptive_color_transform

fef573f

See 8.7.4.6 Residual modification process for blocks using colour space conversion Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/intra: fix scaling process for transform coefficients

86e96a1

See 8.7.3 Scaling process for transform coefficients Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/intra: refact, predict jcbcr to tb->coeffs

d2e7ca6

prepare for adaptive color transform Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc/intra: make lmcs_scale_chroma inplace

ff1ecc7

prepare for adaptive color transform Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

QSXW and others added 10 commits May 17, 2025 09:22

avcodec/vvc/intra: refact out lmcs_scale_chroma and add_residual

0e4c0db

prepare for adaptive color transform Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

avcodec/vvc: add adaptive color transform support

fd5d754

passed files: ACT_A_Kwai_3.bit ACT_B_Kwai_3.bit Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

Changelog: VVC supports all content of SCC

a65d028

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>

add github workflow

7a7905d

Add fuzz regression test

6d7500d

Fix fuzz test path

15b41de

workflow: remove yasm build, since it's disabled by ffmpeg upstream

55b2e1b

add fuzz failed test

62cc30d

workflow: add dvb 40 frames tests

7c90951

workflow: use fuzz flag for fuzz clips

3d2c6ac

nuomi2021 force-pushed the plt branch from 8242475 to 3d2c6ac Compare May 17, 2025 01:35

nuomi2021 closed this May 17, 2025

nuomi2021 mentioned this pull request May 17, 2025

Support PALETTE #8

Closed

Conversation

nuomi2021 commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nuomi2021 commented Apr 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nuomi2021 commented May 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nuomi2021 commented Apr 26, 2025 •

edited

Loading