fix: escaping HasWidth@getWidth return value#19980
Merged
danharrin merged 4 commits intoJun 6, 2026
Merged
Conversation
danharrin
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HasWidth::getWidth()returns an unescaped string that is placed directlyinto a
styleattribute via@stylein two Blade templates:packages/tables/resources/views/index.blade.phppackages/forms/resources/views/components/repeater/table.blade.phpI initially noticed this while working on something else and didn't think it
was worth reporting. After seeing #19885 (same pattern,
ImageColumn/ImageEntrysrcattribute), it felt consistent enough to fix here too (although, in that case, I think it's less security sensitive).e()prevents breaking out of thestyleattribute (e.g.200px" onclick="..."),but CSS property injection remains possible (e.g.
200px; background: red).Happy to add
strtok($width, ';')beforee()if that's considered in scope,but wanted to check first.
Visual changes
None, as long as somebody wasnt using
->widthfor a self-xss-attack.Functional changes
composer cscommand.