fix: overlay parent action modal reopening#19982
Merged
danharrin merged 6 commits intoJun 7, 2026
Merged
Conversation
Change-Id: Ie412d8ad1f279c124de3fc83ef01d7aad4ec4c70
Contributor
|
Thanks for submitting a PR! In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. If your fork belongs to a GitHub organization, please move the repository to your personal account and try again. If you're already using a personal fork, you can learn how to enable maintainer access in the GitHub documentation. |
danharrin
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Ie412d8ad1f279c124de3fc83ef01d7aad4ec4c70
Description
Fixes #19561.
This prevents an action modal from briefly reopening when
overlayParentActions()is used and nested modals are dismissed quickly.When the child modal is closed, Livewire still needs to process the unmount request. If the parent modal is closed locally before that first request finishes, the next Livewire sync can still report the parent action as mounted and reopen the parent modal for a moment.
This keeps the optimistic UI behavior, but tracks action modal nesting indexes that have already been dismissed locally. When Livewire syncs back to an already-dismissed action index, the client skips reopening it.
Related to #19565. That PR also guarded against reopening dismissed modals, but reopening a child modal after closing it required two attempts. This version prunes dismissed child nesting indexes when Livewire syncs back to a parent action, so a child modal can still be reopened on the first attempt.
Visual changes
Recording with Chrome DevTools network throttling set to Slow 4G:
filament-modal-reopening-upload.mp4
Functional changes
composer cscommand.