Repository navigation
Make stacks restored from a GridLayoutDocument resizeable - #2707
Merged
Merged
Conversation
A layout restored from a document has no GridLayoutStackedItem template, so the stacked-content item was created with no resizeable setting and counted as fixed in both directions: no splitters for the stack or its neighbours. When there is no template, take minHeight, minWidth and resizeable from the first stack member. Members share one grid area, and this matches gridSnapshotToGridStackStates and createStack. GridStackSnapshot is unchanged: durable stack metadata stays on the members, so document round-trips already keep it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A layout restored from a
GridLayoutDocumenthas noGridLayoutStackedItemtemplate, so each stack'sstacked-contentitem was created with noresizeablesetting. A missing setting counts as fixed in both directions, so the stack and its neighbours got no splitters, even when every member setresizeable: "hv".Change
useGridLayout.tsx: when there is no stack template, takeminHeight,minWidthandresizeablefrom the first stack member. Members share one grid area, and this matches whatgridSnapshotToGridStackStatesandcreateStackalready do.GridStackSnapshotis unchanged. Stack metadata stays on the members, so a round-trip through the document already keeps it.Tests
GridLayoutDocument.playwright.test.tsx: restores a document with a resizable item beside a stack, checks a splitter exists between them, and checks dragging it changes the column sizes. It fails without the fix and passes with it.🤖 Generated with Claude Code