-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Firebase AI] Use build-for-testing and test-without-building
#15466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ncooke3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
|
Please touch |
Now in progress. One thing to note, since it may be be clear from the default diff view, this only touches the |
|
Oh sorry. I missed the context that it was only for AI Logic. I'm fine to revert the Gemfile change and merge. We can update other products later. |
paulb777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after reverting Gemfile
This reverts commit 6a2088b.
Updated
build.shto use thexcodebuildactionsbuild-for-testingandtest-without-building(instead ofbuildandtest) for the integration tests. This may speed up the GHA sincetestseems to rebuild.#no-changelog