Skip to content

Conversation

@samedson
Copy link
Contributor

Description

We don't yet have a setup where it can login automatically. For dev mode, we're going to rely on your current login.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @samedson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the developer experience for agent evaluations by implementing a mechanism to automatically copy Firebase CLI configuration files during development testing. This change ensures that the agent evaluation tests can utilize the developer's existing authentication credentials, thereby simplifying the setup and execution of tests in a development environment and removing the need for a separate login process.

Highlights

  • Firebase CLI Config Copying: Introduced functionality to copy Firebase CLI configuration files (firebase-tools.json) from the user's home directory to the test environment.
  • Dev Mode Integration: Enabled this configuration copying specifically for the test:dev script by setting the COPY_FIREBASE_CLI_CONFIG environment variable, allowing agent evaluations to utilize the developer's existing Firebase CLI authentication.
  • Improved Developer Workflow: Streamlines the development process for agent evaluations by removing the need for manual authentication setup within the test environment, leveraging existing user credentials.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@samedson samedson requested a review from joehan November 17, 2025 18:00
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a development mode feature to copy local Firebase CLI configuration, allowing tests to use the developer's existing authentication. The changes are mostly in scripts/agent-evals/src/runner/index.ts. My review focuses on improving the robustness of this new functionality. Specifically, I've suggested using a more reliable method to determine the user's home directory and adding error handling to prevent crashes if the configuration file doesn't exist. These changes will make the new feature more stable across different developer environments.

@samedson samedson force-pushed the 1117-samedson-copy-firebase-config branch from 63fcb5e to db15510 Compare November 17, 2025 19:07
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

samedson and others added 3 commits November 18, 2025 09:56
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@samedson samedson force-pushed the 1117-samedson-copy-firebase-config branch from db15510 to 5773116 Compare November 18, 2025 14:56
@samedson samedson enabled auto-merge (squash) November 18, 2025 14:56
@samedson samedson merged commit 86e3888 into master Nov 18, 2025
47 of 48 checks passed
@samedson samedson deleted the 1117-samedson-copy-firebase-config branch November 18, 2025 15:09
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants