-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Agent Evals: Copy Firebase CLI configs in dev mode #9472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @samedson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the developer experience for agent evaluations by implementing a mechanism to automatically copy Firebase CLI configuration files during development testing. This change ensures that the agent evaluation tests can utilize the developer's existing authentication credentials, thereby simplifying the setup and execution of tests in a development environment and removing the need for a separate login process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a development mode feature to copy local Firebase CLI configuration, allowing tests to use the developer's existing authentication. The changes are mostly in scripts/agent-evals/src/runner/index.ts. My review focuses on improving the robustness of this new functionality. Specifically, I've suggested using a more reliable method to determine the user's home directory and adding error handling to prevent crashes if the configuration file doesn't exist. These changes will make the new feature more stable across different developer environments.
63fcb5e to
db15510
Compare
joehan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
db15510 to
5773116
Compare
Description
We don't yet have a setup where it can login automatically. For dev mode, we're going to rely on your current login.