Skip to content

Conversation

@MichaelVerdon
Copy link
Contributor

@MichaelVerdon MichaelVerdon commented Feb 6, 2026

closes #1310

  • This change will display errors and remove them based on keyboard strokes using onChanged instead onBlur to make the UI more responsive. So if you are a few characters short on a password, the error will vanish as soon as you meet the requirements, same with email.
  • This change is applied to all packages
  • Removed onBlur references as it is not required if fields are already validated by onChange()
  • Errors say 8 characters on password is enforced but internally we use 6 so change message to 6.
  • Added tests to verify before and after a valid input

React

Screen.Recording.2026-02-10.at.15.06.28.mov

Angular

Screen.Recording.2026-02-12.at.10.41.34.mov

Shadcn

Screen.Recording.2026-02-12.at.10.49.49.mov

@MichaelVerdon MichaelVerdon marked this pull request as ready for review February 6, 2026 13:47
@russellwheatley russellwheatley self-requested a review February 9, 2026 11:31
@russellwheatley
Copy link
Member

I've made a couple of updates.

  • React - only show errors after a submit attempt or touch by user.
  • Angular - after updating field value, clear any form level. To match React.

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some unit tests for the changes.

  • assert the form state’s errorMap.onSubmit is cleared after typing.
  • creates a form with invalid values, verifies no field validation messages render before submit, triggers handleSubmit(), verifies validation messages appear, then change the input and verify the message clears.

@russellwheatley russellwheatley merged commit 666cacb into main Feb 12, 2026
6 checks passed
@russellwheatley russellwheatley deleted the onChange-forms branch February 12, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validations of user input (email/password/display name) do not clear when user fixes them

2 participants