-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(*): validate errors on form changes #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I've made a couple of updates.
|
russellwheatley
requested changes
Feb 9, 2026
Member
russellwheatley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some unit tests for the changes.
- assert the form state’s errorMap.onSubmit is cleared after typing.
- creates a form with invalid values, verifies no field validation messages render before submit, triggers handleSubmit(), verifies validation messages appear, then change the input and verify the message clears.
russellwheatley
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1310
React
Screen.Recording.2026-02-10.at.15.06.28.mov
Angular
Screen.Recording.2026-02-12.at.10.41.34.mov
Shadcn
Screen.Recording.2026-02-12.at.10.49.49.mov