Skip to content

fix(js/ai/generate): Allow for model to be optional #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssbushi merged 2 commits into from
Dec 9, 2025
Merged

fix(js/ai/generate): Allow for model to be optional #3912

ssbushi merged 2 commits into from
Dec 9, 2025

Conversation

@ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Dec 9, 2025 •
edited
Loading

Before:
image (2)

After:
image

Checklist (if applicable):

@github-actions github-actions bot added the js label Dec 9, 2025
MichaelDoyle
MichaelDoyle reviewed Dec 9, 2025
View reviewed changes
Copy link
Member

@MichaelDoyle MichaelDoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me. Will let Pavel approve.

@ssbushi ssbushi changed the title fix(ai/generate): Allow for model to be optional fix(js/ai/generate): Allow for model to be optional Dec 9, 2025
@ssbushi ssbushi merged commit 6e58dbe into main Dec 9, 2025
5 checks passed
@ssbushi ssbushi deleted the sb/renderExecPrompt branch December 9, 2025 21:01
@ssbushi ssbushi mentioned this pull request Dec 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelDoyle MichaelDoyle MichaelDoyle left review comments

@pavelgj pavelgj pavelgj approved these changes

Assignees

No one assigned

Labels

js

Projects

Genkit Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ssbushi @pavelgj @MichaelDoyle