-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Feat/support Claude code subscription based #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vancelin
wants to merge
9
commits into
firecrawl:main
Choose a base branch
from
vancelin:feat/support-claude-code-subscription-based
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/support Claude code subscription based #148
vancelin
wants to merge
9
commits into
firecrawl:main
from
vancelin:feat/support-claude-code-subscription-based
+2,125
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - ZIP download was failing with 'No active sandbox' error even when sandbox was active - Root cause: Mismatch between V1 (global.activeSandbox) and V2 (global.activeSandboxProvider) architectures - E2B provider's command splitting broke complex bash commands - Different working directories: E2B uses /home/user/app, Vercel uses /vercel/sandbox Solution: - Detect which sandbox provider is active (E2B, Vercel, or V1 legacy) - E2B: Use Python zipfile module directly to avoid command parsing issues - Vercel: Use correct /vercel/sandbox working directory - Maintain backward compatibility with V1 sandboxes Changes: - Provider-aware ZIP creation logic - Python-based implementation for E2B to avoid bash command splitting - Correct path handling for each provider type - Proper output format handling for different providers Testing: - Works with E2B provider using Python zipfile - Works with Vercel provider using correct paths - Maintains V1 sandbox compatibility - ESLint passes with no errors
…ox-provider Fix: ZIP download fails with 'No active sandbox' error for E2B provider
Updated README to include additional demo images.
Add Python FastAPI bridge service to enable Claude Code CLI subscription mode as an alternative to API key authentication. ## New Features - Python FastAPI service (api/python/) bridging Next.js with Claude Code SDK - Startup scripts for Linux/macOS (.sh) and Windows (.bat) - Claude Code client library (lib/claude-code-client.ts) - Status API endpoint (app/api/claude-code/status/route.ts) - Streaming code generation with SSE support ## Documentation - Add comprehensive setup guide in README.md - Add Python API documentation (api/python/README.md) - Add CLAUDE.md with project guidelines for UI design workflow ## Configuration - Update .env.example with Claude Code CLI settings - Add .gitignore rules for temporary files (.claude/, .superdesign/, logs/, src/) - Update app.config.ts with CLI mode support ## Code Quality - All code and comments in English - Python code follows FastAPI best practices - Proper error handling and logging - TypeScript type definitions ## Testing - Add test_sdk.py for SDK validation - Manual testing verified for both API and CLI modes Files changed: 21 files Insertions: ~3,200 lines New files: 11 Modified files: 10
- Add retry mechanism with exponential backoff for Firecrawl API requests - Increase timeout from 30s to 60s to handle queue delays - Simplify API request to only essential formats (markdown, screenshot) - Add better error handling for SCRAPE_TIMEOUT errors - Clean src directory before code generation to ensure fresh starts - Update Claude Code adapter to use fresh sessions (continue_conversation=false) - Change all status messages from Chinese to English for consistency - Simplify CLAUDE.md to only include language preference instructions
This was referenced Oct 11, 2025
8bedc35 to
69bd93b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.