fix: critical token logic bug and add OAuth implementation TODOs #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix inverted isErr() check in to-cloud.ts that was breaking token flow - Add TODO markers at 4 key OAuth integration points: * iframe-fpcc-protocol: Real token exchange needed * fp-cloud-connect-strategy: Popup callback handler needed * page-fpcc-protocol: App ID generation needed * iframe-fpcc-protocol: Device ID integration needed - Leave device-id-protocol.ts actions commented out (incomplete implementation) These changes unblock token flow testing without hiding incomplete work. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
jchris
force-pushed
the
jchris/iframe-noodling
branch
from
28a0889 to
2747020
Compare
Add temporary stub implementation of CAActions.generateSerialNumber to unblock builds while proper serial number generation is implemented. The stub generates a timestamp-based serial number with random suffix. This allows the device-id protocol to compile and function for testing while the OAuth integration work continues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical issues blocking testing of the iframe auth implementation in PR #1279, without interfering with active development work.
Changes
🔴 Critical Bug Fix
isErr()check that was breaking token flow!rToken.isErr(property exists) instead ofrToken.isErr()(is error)🔧 Build Fix
CAActionsimportactionsparameter optional in interface📝 Developer Guidance
Added TODO markers at 4 key locations where OAuth implementation needs completion:
What This Enables
✅ TypeScript builds successfully (core modules)
✅ Token flow can be tested without silent failures
✅ Clear guidance on next implementation steps
✅ Doesn't remove console.logs or mock implementations (needed for dev)
Testing
Build passes:
No changes to test behavior - this unblocks testing infrastructure.
🤖 Generated with Claude Code