Documentation branch #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
reviewed
Aug 15, 2018
brainconn/centrality/centrality.py
Outdated
| Cs = np.real(np.dot(vecs * vecs, np.exp(vals))) | ||
| return Cs # imaginary part from precision error | ||
|
|
||
| def Leverage_centrality: |
Member
There was a problem hiding this comment.
You need to define functions with parentheses, even if they're empty. We also need to include the word "pass" when the function isn't running yet.
So instead of
def Leverage_centrality:
"""Documentation...
"""we should have:
def Leverage_centrality():
"""Documentation...
"""
pass
tsalo
reviewed
Aug 15, 2018
brainconn/centrality/centrality.py
Outdated
| """ | ||
|
|
||
| def Delta_centrality (G): |
Member
There was a problem hiding this comment.
Function names should be lower snake case, so Delta_centrality --> delta_centrality, Degree_centrality --> degree_centrality, Leverage_centrality --> leverage_centrality.
tsalo
reviewed
Aug 15, 2018
brainconn/centrality/centrality.py
Outdated
| betweenness centrality participate in a large number of shortest paths. | ||
Member
There was a problem hiding this comment.
We also don't want these extra spaces here.
Member
|
These changes look good, but I'll hold off on merging the PR until we consolidate some functions and address the failing tests in other work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # .
Changes proposed in this pull request: