Create new employee history start date default by fivetran-avinash · Pull Request #29 · fivetran/dbt_workday

fivetran-avinash · 2026-03-26T02:01:50Z

PR Overview

Package version introduced in this PR:

v0.9.0

This PR addresses the following Issue/Feature(s):

GA-1020281

Summary of changes:

Add workday history start date filter

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR

Changelog

Draft changelog for PR
Final changelog for release review

fivetran-catfritz · 2026-03-30T21:06:25Z

+|  `workday__employee_daily_history` <br> `workday__worker_position_org_daily_history` | Data change | Default `employee_history_start_date` = `2005-03-01` | Default `employee_history_start_date` = `2025-03-01` | Aligns the dbt Core default with the Quickstart default. Users who do not explicitly set `employee_history_start_date` will now receive just over one year of history instead of all available history by default. See how to configure the `employee_history_start_date` to another date in the README. |
+
+## Bug Fixes
+- Fixed an issue where `workday__employee_daily_history` and `workday__worker_position_org_daily_history` would fail on Snowflake with a `Date 'None' is not recognized` error. The models now handle null results gracefully by falling back to the `employee_history_start_date` variable and today's date respectively.


Suggested change

- Fixed an issue where `workday__employee_daily_history` and `workday__worker_position_org_daily_history` would fail on Snowflake with a `Date 'None' is not recognized` error. The models now handle null results gracefully by falling back to the `employee_history_start_date` variable and today's date respectively.

- Fixes an issue where `workday__employee_daily_history` and `workday__worker_position_org_daily_history` would fail on Snowflake with a `Date 'None' is not recognized` error. The models now handle null values by falling back to the `employee_history_start_date` variable and the current date respectively.

fivetran-catfritz · 2026-03-30T21:34:20Z

These two end models should need the flags.which..., otherwise the section meant for compilation will never kick in.

Ahhh good catch. Added.

fivetran-catfritz · 2026-03-30T21:40:42Z

    {{ dbt_utils.date_spine(
        datepart="day",
-        start_date = "greatest(cast('" ~ start_date[0:10] ~ "' as date), cast('" ~ var('employee_history_start_date','2005-03-01') ~ "' as date))", 
+        start_date = "greatest(cast('" ~ start_date[0:10] ~ "' as date), cast('" ~ var('employee_history_start_date','2025-03-01') ~ "' as date))", 


It looks like this is the only place the '2025-03-01' default is applied. If we introduce the default earlier, we could likely avoid some of these downstream cleaning steps. Or is there a reason we only want to bring it in at this stage?

Also, is it that we are expecting None during compilation, or are there cases where min and max dates truly wouldn’t exist? flags.which should address the compilation scenario.

Re: '2025-03-01'
Because it's a history model, we want to maintain all records at the staging layer to avoid data loss. We apply it here since we are only looking to bound the spine, since the daily history is most at risk of row explosion.

We don't apply this upstream because there's a risk of records being cut off. For example, if there's a record with a _fivetran_start on 2025-01-01 and a _fivetran_end after 2025-06-01, that record wouldn't be captured in a staging filter, and the employee history would be empty from March to June.

Re: None
I believe this was to avoid empty source table errors when both the min/max calls would return null and thus None in Jinja.

fivetran-catfritz · 2026-03-30T21:41:02Z

same comments as workday__employee_daily_history.

…s://github.com/fivetran/dbt_workday into bugfix/employee-history-new-start-date-default

fivetran-catfritz

Thanks for the responses. This is good for pre-release!

…gfix/employee-history-new-start-date-default

* Schema Change: Deprecate support for oldtables * Create new employee history start date default (#29) * Create new employee history start date default * Identifier fix for employee history start date * Generate dbt docs via GitHub Actions * PR review * spine refactor * Generate dbt docs via GitHub Actions * Generate dbt docs via GitHub Actions --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Final checks * schema & changelog * Final touchups * Generate dbt docs via GitHub Actions * data type * schema * CHANGELOG reversion/PR review * Generate dbt docs via GitHub Actions --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Create new employee history start date default

ac12cff

fivetran-avinash self-assigned this Mar 26, 2026

fivetran-avinash marked this pull request as ready for review March 26, 2026 02:11

Identifier fix for employee history start date

bd6439e

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Mar 27, 2026

Generate dbt docs via GitHub Actions

2757baf

fivetran-catfritz reviewed Mar 30, 2026

View reviewed changes

fivetran-avinash added 2 commits March 30, 2026 16:24

PR review

b943999

Merge branch 'bugfix/employee-history-new-start-date-default' of http…

84914ae

…s://github.com/fivetran/dbt_workday into bugfix/employee-history-new-start-date-default

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Mar 30, 2026

spine refactor

b72d029

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Mar 31, 2026

Generate dbt docs via GitHub Actions

6dee892

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Mar 31, 2026

Generate dbt docs via GitHub Actions

40c8376

fivetran-catfritz reviewed Mar 31, 2026

View reviewed changes

fivetran-avinash added the pre-release Triggers the auto-releaser workflow. label Mar 31, 2026

fivetran-avinash changed the base branch from main to schema-change/deprecate-support-for-old-tables April 7, 2026 19:57

Merge branch 'schema-change/deprecate-support-for-old-tables' into bu…

bee52d8

…gfix/employee-history-new-start-date-default

fivetran-avinash merged commit c8aca9d into schema-change/deprecate-support-for-old-tables Apr 7, 2026
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create new employee history start date default#29

Create new employee history start date default#29
fivetran-avinash merged 9 commits into
schema-change/deprecate-support-for-old-tablesfrom
bugfix/employee-history-new-start-date-default

fivetran-avinash commented Mar 26, 2026 •

edited

Loading

Uh oh!

fivetran-catfritz Mar 30, 2026

Uh oh!

fivetran-catfritz Mar 30, 2026

Uh oh!

fivetran-avinash Mar 30, 2026 •

edited

Loading

Uh oh!

fivetran-catfritz Mar 30, 2026

Uh oh!

fivetran-avinash Mar 30, 2026 •

edited

Loading

Uh oh!

fivetran-catfritz Mar 30, 2026

Uh oh!

fivetran-avinash Mar 30, 2026

Uh oh!

fivetran-catfritz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	- Fixed an issue where `workday__employee_daily_history` and `workday__worker_position_org_daily_history` would fail on Snowflake with a `Date 'None' is not recognized` error. The models now handle null results gracefully by falling back to the `employee_history_start_date` variable and today's date respectively.
	- Fixes an issue where `workday__employee_daily_history` and `workday__worker_position_org_daily_history` would fail on Snowflake with a `Date 'None' is not recognized` error. The models now handle null values by falling back to the `employee_history_start_date` variable and the current date respectively.

Conversation

fivetran-avinash commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-catfritz Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fivetran-avinash commented Mar 26, 2026 •

edited

Loading

fivetran-avinash Mar 30, 2026 •

edited

Loading

fivetran-avinash Mar 30, 2026 •

edited

Loading