Make list comparison accept lists in documents and support matching networks

[ppcad]

No description provided.

[mhoff]

@ppcad Thank you for the PR!

I think it would be more suitable to have a dedicated processor for this kind of functionality, which might/should extend the list_comparison processor. This new processor would then only expect ip addresses or ip address ranges and could then specialize on this functionality.

Advantages:

• Fine-granular processors
• No or less try...except flows for happy path scenarios
• No complex branching logic if further formats are to be supported (e.g. regex, ...)

What do you think?

[ppcad]

@ppcad Thank you for the PR!

I think it would be more suitable to have a dedicated processor for this kind of functionality, which might/should extend the list_comparison processor. This new processor would then only expect ip addresses or ip address ranges and could then specialize on this functionality.

Advantages:

* Fine-granular processors

* No or less try...except flows for happy path scenarios

* No complex branching logic if further formats are to be supported (e.g. regex, ...)

What do you think?

Yes, it may be better extract this functionality into a dedicated processor. Do you think that the new processor should inherit from list comparison or should it be a separate processor?

[mhoff]

I think inheriting from list comparison makes sense!

[ppcad]

@mhoff could you please take a look now?

[mhoff]

Hello @ppcad, many thanks for the proposed changes.

Please have a look at my comments. Typically the comments apply to both, the ng and non-ng, versions. Feel free to reply or reach out if there is anything to discuss!

[mhoff]

Many thanks, I did a second review pass with a few remarks

[mhoff]

Many thanks for the changes. I found one more small bit

[mhoff]

Thank you for the changes. The compose setup tests can be disregarded for now