Support key-as-segment for navigation properties (#299)#877
Merged
Conversation
Deleting or otherwise operating on a nested child entity via the key-as-segment URL form (e.g. /Flights/1/passengers/3) returned 404 because PathSegment\Key only accepted a raw EntitySet. A navigation property that resolves to a collection arrives wrapped in a PropertyValue, so the trailing key segment was never handled. Unwrap a PropertyValue whose value is an EntitySet so a following key segment selects a single related entity, mirroring the already-working parenthesised form (/Flights(1)/passengers(3)). Adds regression tests (Eloquent + SQL drivers) covering GET, PATCH and DELETE of a nested entity via both the parenthesised and key-as-segment URL forms. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting or otherwise operating on a nested child entity via the key-as-segment URL form (e.g. /Flights/1/passengers/3) returned 404 because PathSegment\Key only accepted a raw EntitySet. A navigation property that resolves to a collection arrives wrapped in a PropertyValue, so the trailing key segment was never handled.
Unwrap a PropertyValue whose value is an EntitySet so a following key segment selects a single related entity, mirroring the already-working parenthesised form (/Flights(1)/passengers(3)).
Adds regression tests (Eloquent + SQL drivers) covering GET, PATCH and DELETE of a nested entity via both the parenthesised and key-as-segment URL forms.