Support $count on navigation properties in $filter (#871)#878
Open
Remo wants to merge 1 commit into
Open
Conversation
Using `$count` on a collection-valued navigation property within a
filter expression (e.g. `?$filter=passengers/$count eq 0`) previously
threw a cryptic parser error ("Encountered an invalid symbol at:
passengers/>$<count eq 0") because the filter parser had no tokenizer
for the `navigationProperty/$count` syntax.
Add a Count expression node and a parser tokenizer that recognises
`navigationProperty/$count`. On SQL drivers this compiles to a
correlated `( SELECT COUNT(*) FROM <related> WHERE <constraints> )`
subquery built from the navigation binding's referential constraints,
so it can be compared like any other operand (eq, ne, gt, ge, lt, le)
and combined with logical operators. This works on all SQL drivers
including SQLite.
Drivers that cannot express it (in-memory collection drivers and
MongoDB) now throw a clear NotImplementedException instead of a parser
error.
Adds cross-dialect parser tests (generated SQL for MySQL, PostgreSQL,
SQLite, SQLServer) and functional tests (Eloquent + SQL drivers).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
$counton a collection-valued navigation property within a filter expression (e.g.?$filter=passengers/$count eq 0) previously threw a cryptic parser error ("Encountered an invalid symbol at: passengers/>$<count eq 0") because the filter parser had no tokenizer for thenavigationProperty/$countsyntax.Add a Count expression node and a parser tokenizer that recognises
navigationProperty/$count. On SQL drivers this compiles to a correlated( SELECT COUNT(*) FROM <related> WHERE <constraints> )subquery built from the navigation binding's referential constraints, so it can be compared like any other operand (eq, ne, gt, ge, lt, le) and combined with logical operators. This works on all SQL drivers including SQLite.Drivers that cannot express it (in-memory collection drivers and MongoDB) now throw a clear NotImplementedException instead of a parser error.
Adds cross-dialect parser tests (generated SQL for MySQL, PostgreSQL, SQLite, SQLServer) and functional tests (Eloquent + SQL drivers).