Clone singletons per-request for Octane safety (#870)#879
Open
Remo wants to merge 1 commit into
Open
Conversation
The Lodata model is a container singleton, so under Laravel Octane it and every resource it holds stay resident in memory and are reused across requests. Entity sets and operations were already cloned before any request-scoped state was attached to them, but Singleton::pipe() returned the shared instance directly. During the request cycle Entity::get() and emitJson() then mutated that shared object (setting metadata, advancing the propertyValues iterator, and appending null/generated/computed/navigation property values), leaking and accumulating state across requests. Clone the singleton in Singleton::pipe(), and give ComplexValue a __clone() that deep-clones the property value collection and resets the metadata so the existing per-request mutations land on the clone rather than the shared model instance. Adds a regression test that reuses the singleton model across multiple simulated requests and asserts the shared instance is left untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lodata model is a container singleton, so under Laravel Octane it and every resource it holds stay resident in memory and are reused across requests. Entity sets and operations were already cloned before any request-scoped state was attached to them, but Singleton::pipe() returned the shared instance directly. During the request cycle Entity::get() and emitJson() then mutated that shared object (setting metadata, advancing the propertyValues iterator, and appending null/generated/computed/navigation property values), leaking and accumulating state across requests.
Clone the singleton in Singleton::pipe(), and give ComplexValue a __clone() that deep-clones the property value collection and resets the metadata so the existing per-request mutations land on the clone rather than the shared model instance.
Adds a regression test that reuses the singleton model across multiple simulated requests and asserts the shared instance is left untouched.