Open
Conversation
…ect exit code will be returned
Owner
|
@ses1112 thank you for your contribution. These are interesting problems. Potentially the killing of subprocesses should be configurable. What do you think? |
Author
|
Configurable sounds good, should this be a method in the ProcBuilder? And default false because of compatibility to older versions? I can try to create a test for interrupting a running process, but for subprocess i don't know how i could make one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adresses to issues: Killing subprocesses and interrupting of a running process.
Subprocesses
If a process spawns subprocesses, these processes are not destroyed in killProcessCleanup. Therefor are ProcessHandle is necessary.
** Interrupting **
A running process can be stopped if the corresponding thread is interrupted. If this happens, no exit code is available. If a java process is destroyed, the process returns exit code 1.
Change: If the thread is interrupted, the process is killed/destroyed, but no exception is thrown. The control thread finishs normally and sets the exit code to 1 and dispatches the event "PROCESS_EXITED". The original thread finishs also normally without exception. In ProcBuilder the correct result will be created.