EDM-3515: Make Red Hat logo readable in light theme#572
EDM-3515: Make Red Hat logo readable in light theme#572celdrake wants to merge 1 commit intoflightctl:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
WalkthroughIntroduces a new useBrandLogo hook that centralizes logo selection logic based on app settings and user theme preferences. Updates AppLayout and LoginPageLayout components to use the hook instead of direct conditional rendering. Removes duplicate logo asset imports and conditional logic from both components. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can validate your CodeRabbit configuration file in your editor.If your editor has YAML language server, you can enable auto-completion and validation by adding |
The Red Hat logo needs a new variant with Dark letters, given that the
Mastheadin Patternfly 6 now adapts to the dark/light theme. See https://v5-archive.patternfly.org/components/masthead with a light theme, it's always Dark.Mastheadand in the "Select auth provider" screen.Summary by CodeRabbit