Repository navigation
Conversation
With WindowPadding at 0 the fixed +11 px left a visible strip under the last row. End the window at the last line box instead, plus the 2 font px imgui's rounding can put descenders past it and the outline thickness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2111.
hud_compact sets WindowPadding to 0, but the window still ends 11 px past the cursor, leaving a strip under the last row that the top and sides don't have. It now ends at the last line box, plus the 2 px imgui's rounding can put descenders below it and the outline thickness. Other layouts keep the +11.
Gap under the lowest text pixel on glxgears screenshots with
background_color=ff00ff,legacy_layout=0,gpu_stats,cpu_stats,fps,exec_name, master -> this, at font_size 16/24/64: hud_compact goes 4/3/2 -> 0/0/0, hud_compact + horizontal 7/6/12 -> 3/3/10. Non-compact layouts are unchanged. Withtext_outline=0it's 5 -> 0, and a positivecellpadding_ystays on both edges (0.5: top 7, bottom 12 -> 8).What horizontal keeps is the main font's descent. Nothing there draws a descender by default, but I didn't want to clip one from a custom font.