Skip to content

fix(landing): polish pass — OSS triple-cleanup, dead CSS, hover-pause, copy handler, chip layout, reduced-motion#43

Open
federicodeponte wants to merge 3 commits intofeat/landing-reset-2026-05-06from
fix/landing-polish-2026-05-06
Open

fix(landing): polish pass — OSS triple-cleanup, dead CSS, hover-pause, copy handler, chip layout, reduced-motion#43
federicodeponte wants to merge 3 commits intofeat/landing-reset-2026-05-06from
fix/landing-polish-2026-05-06

Conversation

@federicodeponte
Copy link
Copy Markdown
Member

Summary

Stacks on feat/landing-reset-2026-05-06 (PR #40). Six self-roast items closed in one train.

1. OSS triple-redundancy (Federico-flagged)

  • Eyebrow stripped from "Skills for agents · Open source" → "Skills for agents"
  • <a className="landing-oss-badge"> block deleted from below CTAs
  • Nav GitHub link is the sole above-fold OSS signal; trust strip still mentions MIT

2. Dead CSS culled (~140 lines)

All classes verified unused (grep confirmed) after orbit chips were replaced:
.landing-orbit-*, .landing-orbit-chip-*, .landing-hero-card, .landing-hero-mascot, .landing-hero-skill-*, .landing-hero-save-btn, .landing-hero-callout, .landing-hero-skill-meta-row, .landing-oss-badge, .landing-oss-star

3. Rotation pauses on hover + off-screen

onMouseEnter/Leave pauses/resumes interval. IntersectionObserver (threshold 0.1) pauses when card is <10% visible. No new dependencies.

4. Copy icon — real handler

navigator.clipboard.writeText(skillUrl) + 1.5s <Check> checkmark state. Wrapped in a <button> with proper aria-label and focus-visible ring.

5. Auto-updating chip — tucked below Save button

Chip moved inside .landing-hero-card-v2-save-group flex column with gap: 6px, visually grouped with the Save CTA. Matches Federico's reference image.

Chip layout variants considered:

  • Shipped: Below Save in same flex column (gap 6px) — tightest grouping, chip reads as a property of the button, matches reference image
  • Alt A: Inline badge attached to right side of button — requires wider button, can clip on mobile
  • Alt B: Micro-text below button at center alignment — less visually grouped, more like a caption

6. Reduced-motion fix

useEffect now checks reduce directly — interval is fully skipped (not just transitions) when prefers-reduced-motion: reduce. First card shown statically.

Verification

  • grep -c 'Skills for agents · Open source' web/src/app/LandingPage.tsx = 0
  • grep -c 'landing-oss-badge' web/src/app/LandingPage.tsx = 0
  • grep -c 'landing-orbit' web/src/app/landing.css = 0 (class removed)
  • TypeScript: tsc --noEmit clean
  • Build: Compiled successfully in 4.5s — sitemap env error pre-exists on base branch

Test plan

  • Hover hero card — rotation stops, resumes on mouseout
  • Scroll hero card out of view — rotation stops, resumes when scrolled back
  • Click copy icon — checkmark shows for 1.5s, URL in clipboard
  • Auto-updating chip appears below Save button, tightly grouped
  • Set prefers-reduced-motion: reduce in DevTools — card pins to first skill, no rotation
  • Eyebrow reads "Skills for agents" only (not "· Open source")
  • No .landing-oss-badge element in DOM

🤖 Generated with Claude Code

@federicodeponte federicodeponte force-pushed the feat/landing-reset-2026-05-06 branch from 6c70eb5 to c6e8452 Compare May 7, 2026 02:25
Floom and others added 3 commits May 7, 2026 04:25
…tion magic

Squash of PR #40 (feat/landing-reset-2026-05-06):
- Aurora bg: 3-layer watercolor emerald sweep (right-edge, per ChatGPT ref image)
- LandingHeroCard: rotating B2 skill cards with appleEase transitions
- Kill "Start here / Three commands" dev-facing section
- Sub-copy shortened to single row: "Save it. Send the link. Your agent adds it."
- Apple motion: appleSpring + whileInView once:true margin:-100px on all sections
- appleEase applied to all hero card transitions (Kimi audit pass)
- DESIGN.md updated: §6.5 aurora opacity 0.20+, §9 motion contract

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…, copy handler, chip layout, reduced-motion

1. OSS triple-redundancy removed: eyebrow is now "Skills for agents" (no " · Open source"),
   landing-oss-badge block deleted. Nav GitHub link is the sole above-fold OSS signal.
   landing-oss-badge/.landing-oss-star CSS deleted.

2. Dead CSS culled (~140 lines): .landing-orbit-*, .landing-orbit-chip-*,
   .landing-hero-card, .landing-hero-mascot, .landing-hero-skill-*,
   .landing-hero-save-btn, .landing-hero-callout, .landing-hero-skill-meta-row —
   all verified unused after orbit chips were replaced by LandingHeroCard.

3. Hero card rotation pauses on hover (onMouseEnter/Leave) and when scrolled
   off-screen (IntersectionObserver) with no new dependencies.

4. URL bar copy icon wired to navigator.clipboard.writeText + 1.5s Check
   checkmark state. New .landing-hero-card-v2-urlbar-copy-btn button wrapper.

5. Auto-updating chip moved inline below Save button in a flex column
   (landing-hero-card-v2-save-group), matching Federico's reference image tight grouping.

6. Reduced-motion fix: interval is now fully skipped (not just animations)
   when useReducedMotion() returns true — first skill shown statically.

Build: TypeScript clean, Next.js compiled successfully (sitemap env error is pre-existing infra issue on all branches).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@federicodeponte federicodeponte force-pushed the fix/landing-polish-2026-05-06 branch from f53d0c3 to 275234e Compare May 7, 2026 02:26
federicodeponte pushed a commit that referenced this pull request May 7, 2026
…, copy handler, chip layout, reduced-motion (#43)

- OSS triple-redundancy: eyebrow stripped to "Skills for agents" (no "· Open source")
- Deleted below-CTA OSS badge; nav GitHub icon is sole OSS signal
- Dead CSS culled: ~140 lines landing-orbit-*, hero-card, oss-badge removed
- Hero card rotation pauses on hover + IntersectionObserver off-screen pause
- Copy icon: real navigator.clipboard handler + 1.5s checkmark state
- Auto-updating chip tucked below Save button in flex column (gap: 6px)
- Reduced-motion: interval fully skipped when prefers-reduced-motion: reduce

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
federicodeponte pushed a commit that referenced this pull request May 7, 2026
All 5 PRs (#38, #39, #40, #43, #41) merged to main. Launch evidence screenshots
saved to /root/floom-internal/launch-evidence/v0-launch-2026-05-06/.
Email layer reconciled (Hybrid Layer A+B, 9 templates, 18 tests passing).
Pending: RESEND_API_KEY (Federico), Supabase template paste, skills-minimal-deploy git wire.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant