Added an idea of a password checker #1060
Conversation
WalkthroughAdded two new beginner-level project specification Markdown files: a Password Strength Checker and a Weather Dashboard, each listing user stories, core feature checklists, bonus features, useful links, and example project references. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Projects/1-Beginner/Password-Strength-Checker.md (1)
11-15: Fix Markdown list indentation to maintain style consistency.The nested list items (lines 11-15) use 4-space indentation, but the Markdown linting standard expects 2-space indentation for nested lists. This is flagged by the MD007 rule in markdownlint-cli2.
Apply this diff to fix the indentation:
- [ ] User can see strength indicators as they type: - - Password length (minimum 8 characters) - - Contains uppercase letters - - Contains lowercase letters - - Contains numbers - - Contains special characters + - Password length (minimum 8 characters) + - Contains uppercase letters + - Contains lowercase letters + - Contains numbers + - Contains special characters
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Projects/1-Beginner/Password-Strength-Checker.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
Projects/1-Beginner/Password-Strength-Checker.md
11-11: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
12-12: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
13-13: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
14-14: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
15-15: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
🔇 Additional comments (1)
Projects/1-Beginner/Password-Strength-Checker.md (1)
1-38: Excellent project specification for a beginner-level task.The documentation is well-structured with clear user stories, realistic bonus features, and relevant learning resources. The combination of core features (strength indicators, real-time feedback, suggestions) and bonus features (password generation, visibility toggle, crack-time estimation) provides a good progression path for learners. The curated links and example projects are particularly helpful references.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Projects/1-Beginner/Weather-Dashboard.md (1)
36-40: Consider adding brief descriptions to example projects.The example projects are good references, but learners would benefit from understanding why each is included. Adding a sentence describing what makes each example valuable (e.g., "demonstrates React hooks usage," "shows vanilla JS approach," "features a polished UI") would help learners choose which example best fits their learning goals.
Example enhancement:
## Example projects - [Weather App with React](https://github.com/ayushkul/react-weather-app) - [Vanilla JS Weather App](https://github.com/avinash-kr-pandey/Weather_app) - [Weather Dashboard Demo](https://weather-dashboard.netlify.app/) + [Weather App with React](https://github.com/ayushkul/react-weather-app) - Demonstrates React component patterns + [Vanilla JS Weather App](https://github.com/avinash-kr-pandey/Weather_app) - Shows how to build without frameworks + [Weather Dashboard Demo](https://weather-dashboard.netlify.app/) - Polished UI/UX reference implementation
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Projects/1-Beginner/Weather-Dashboard.md(1 hunks)
🔇 Additional comments (1)
Projects/1-Beginner/Weather-Dashboard.md (1)
1-14: Project specification is well-structured for beginners.The user stories are appropriately scoped for a beginner project, with clear and achievable core functionality. The progression from basic features (search, display) to more interactive elements (temperature toggle, forecasts) provides good learning outcomes.
Update title to 'Password Strength Checker Idea'
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Projects/1-Beginner/Password-Strength-Checker.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
Projects/1-Beginner/Password-Strength-Checker.md
11-11: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
12-12: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
13-13: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
14-14: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
15-15: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
🔇 Additional comments (1)
Projects/1-Beginner/Password-Strength-Checker.md (1)
1-39: Well-structured beginner project specification.The content is clear, appropriately scoped, and includes solid user stories with well-chosen bonus features. The resource links are relevant and helpful for someone tackling this project. The criteria for password strength (length, character variety) align with industry best practices.
| - [ ] User can see strength indicators as they type: | ||
| - Password length (minimum 8 characters) | ||
| - Contains uppercase letters | ||
| - Contains lowercase letters | ||
| - Contains numbers | ||
| - Contains special characters |
There was a problem hiding this comment.
Fix markdown list indentation to comply with formatting standards.
Lines 11-15 have incorrect indentation (4 spaces instead of 2). Apply this diff to align with markdown linting standards:
- [ ] User can see strength indicators as they type:
- - Password length (minimum 8 characters)
- - Contains uppercase letters
- - Contains lowercase letters
- - Contains numbers
- - Contains special characters
+ - Password length (minimum 8 characters)
+ - Contains uppercase letters
+ - Contains lowercase letters
+ - Contains numbers
+ - Contains special charactersCommittable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
11-11: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
12-12: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
13-13: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
14-14: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
15-15: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
🤖 Prompt for AI Agents
In Projects/1-Beginner/Password-Strength-Checker.md around lines 10 to 15, the
nested markdown list items use 4-space indentation instead of the required
2-space indentation; update lines 11–15 so each sub-list item is indented by 2
spaces (not 4) under the parent checkbox line to satisfy markdown linting and
maintain consistent list nesting.
1 participant
Added is a password strength checker as an idea.
Summary by CodeRabbit