-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Added a new idea #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added a new idea #1067
Conversation
WalkthroughThis PR adds two new beginner-level project specifications as Markdown documents: a Password Strength Checker and a Weather Dashboard. Both files outline project goals, user stories, bonus features, and resources without containing executable code. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
Projects/1-Beginner/Weather-Dashboard.md (1)
9-9: Consider mentioning API key requirement in core user story.While the OpenWeather API is a popular choice, users need to know they'll need to obtain a free API key before implementing this project. Consider rephrasing line 9 to hint at this (e.g., "User can enter a city name to get weather information (requires OpenWeather API key)") or add this as a prerequisite note near the top of the document.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Projects/1-Beginner/Password-Strength-Checker.md(1 hunks)Projects/1-Beginner/Weather-Dashboard.md(1 hunks)
| - [zxcvbn - Password Strength Estimation Library](https://github.com/dropbox/zxcvbn) | ||
| - [MDN Web Docs - Regular Expressions](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions) | ||
| - [How to Create a Strong Password (Article)](https://www.security.org/how-secure-is-my-password/) | ||
| - [HTML DOM Input Password](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/password) | ||
|
|
||
| ## Example projects | ||
|
|
||
| - [Password Strength Checker with zxcvbn](https://codepen.io/preserveddarnell/pen/oNNQxQm) | ||
| - [Password Strength Meter](https://github.com/pascalbell/password-strength-meter) | ||
| - [React Password Strength Checker](https://github.com/mloureiro/react-password-strength) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify external links and example project references.
The resource links and example projects should be validated to ensure they remain current and accessible. Given that documentation may become stale, please verify:
- The zxcvbn library link and its current status
- The MDN documentation links
- The CodePen and GitHub example projects are still available and provide relevant implementations
Run the following script to verify link accessibility:
🏁 Script executed:
#!/bin/bash
# Description: Verify that external links in Password-Strength-Checker.md are accessible
links=(
"https://github.com/dropbox/zxcvbn"
"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions"
"https://www.security.org/how-secure-is-my-password/"
"https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/password"
"https://codepen.io/preserveddarnell/pen/oNNQxQm"
"https://github.com/pascalbell/password-strength-meter"
"https://github.com/mloureiro/react-password-strength"
)
for link in "${links[@]}"; do
status=$(curl -s -o /dev/null -w "%{http_code}" "$link")
echo "$link - Status: $status"
doneLength of output: 493
Remove or replace broken example project links.
Three of the example projects are no longer accessible:
- CodePen
preserveddarnell/pen/oNNQxQmreturns 403 (Forbidden) pascalbell/password-strength-meterrepository returns 404 (deleted)mloureiro/react-password-strengthrepository returns 404 (deleted)
Either remove these non-functional links or replace them with current, accessible implementations that demonstrate password strength validation.
🤖 Prompt for AI Agents
In Projects/1-Beginner/Password-Strength-Checker.md around lines 30–39, three
example project links are broken (CodePen preserveddarnell/pen/oNNQxQm returns
403; pascalbell/password-strength-meter and mloureiro/react-password-strength
return 404); remove those non-functional links or replace them with live,
accessible examples (e.g., the official zxcvbn repo demo, an OWASP/MDN example,
or a working CodePen/GitHub repo demonstrating password strength meters), and
verify each replacement URL loads successfully before committing.
| - [OpenWeather API](https://openweathermap.org/api) - Free weather data API | ||
| - [Geolocation API](https://developer.mozilla.org/en-US/docs/Web/API/Geolocation_API) | ||
| - [Weather Icons](https://erikflowers.github.io/weather-icons/) | ||
| - [localStorage API](https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage) | ||
| - [Chart.js](https://www.chartjs.org/) - For temperature graphs | ||
| - [Leaflet](https://leafletjs.com/) - For weather maps | ||
|
|
||
| ## Example projects | ||
|
|
||
| - [Weather App with React](https://github.com/ayushkul/react-weather-app) | ||
| - [Vanilla JS Weather App](https://github.com/avinash-kr-pandey/Weather_app) | ||
| - [Weather Dashboard Demo](https://weather-dashboard.netlify.app/) No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify external links and clarify API requirements.
The resources and example projects should be validated. Additionally, consider adding a note about API key requirements:
- The OpenWeather API (line 29) requires free registration and an API key—this should be mentioned in the user stories or bonus features to set expectations
- Verify all resource links remain current and accessible
- Confirm the example projects are still maintained and provide relevant implementations
Run the following script to verify link accessibility:
🏁 Script executed:
#!/bin/bash
# Description: Verify that external links in Weather-Dashboard.md are accessible
links=(
"https://openweathermap.org/api"
"https://developer.mozilla.org/en-US/docs/Web/API/Geolocation_API"
"https://erikflowers.github.io/weather-icons/"
"https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage"
"https://www.chartjs.org/"
"https://leafletjs.com/"
"https://github.com/ayushkul/react-weather-app"
"https://github.com/avinash-kr-pandey/Weather_app"
"https://weather-dashboard.netlify.app/"
)
for link in "${links[@]}"; do
status=$(curl -s -o /dev/null -w "%{http_code}" "$link")
echo "$link - Status: $status"
doneLength of output: 517
Fix broken example project link and document API key requirement.
One of the example projects is no longer accessible:
https://github.com/avinash-kr-pandey/Weather_appreturns a 404—remove this link or replace with a working alternative
Additionally, the OpenWeather API requires free registration for an API key. This dependency should be mentioned in the user stories or bonus features to set expectations for developers using this project.
🤖 Prompt for AI Agents
In Projects/1-Beginner/Weather-Dashboard.md around lines 29 to 40, one example
project link (https://github.com/avinash-kr-pandey/Weather_app) is broken and
the OpenWeather API dependency lacks mention of the required API key; remove or
replace the broken GitHub link with a working alternative (or drop it), and
update the project description or user stories/bonus features to explicitly
state that OpenWeather requires free registration for an API key and where to
place it (e.g., environment variable or config) so contributors know this
prerequisite.
Summary by CodeRabbit
Release Notes