[material_ui, cupertino_ui] Localizations by justinmc · Pull Request #12119 · flutter/packages

justinmc · 2026-07-06T20:25:46Z

This PR attempts to solve the flutter_localizations problem for material_ui and cupertino_ui. The crux of the problem is that apps that import flutter_localizations were getting a version of GlobalMaterialLocalizations that uses flutter/flutter's MaterialLocalizations instead of the one in material_ui (and the same thing for Cupertino). This PR moves these classes into material_ui and cupertino_ui, while keeping other localization code inside flutter_localizations.

How this PR was created

Similar to #11888, this PR copies history from flutter/flutter. All commits are preserved as-is, plus one final commit from me that is a squash of all of my work on this PR. This PR should be landed as a merge without squash.

git filter-repo --path-glob "packages/flutter_localizations/lib/src/l10n/cupertino_*.arb" --path packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart --path packages/flutter_localizations/lib/src/cupertino_localizations.dart --path packages/flutter_localizations/test/cupertino/ --path-glob "packages/flutter_localizations/lib/src/l10n/material_*.arb" --path packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart --path packages/flutter_localizations/lib/src/material_localizations.dart --path packages/flutter_localizations/test/material --path packages/flutter_localizations/test/test_utils.dart --path dev/tools/localization/gen_cupertino_localizations.dart --path dev/tools/localization/gen_material_localizations.dart --path dev/tools/localization/language_subtag_registry.dart --path dev/tools/localization/localizations_utils.dart --path dev/tools/localization/localizations_validator.dart --path dev/tools/localization/bin/encode_kn_arb_files.dart --path dev/tools/localization/bin/gen_localizations.dart --path dev/tools/localization/bin/gen_missing_localizations.dart
cd ../packages
git remote add source-origin ../flutter
git fetch source-origin
git merge source-origin/master --allow-unrelated-histories

Before

As described in flutter/flutter#188757, a typical localized app like the following would encounter runtime type errors:

import 'package:flutter_localizations/flutter_localizations.dart';
import 'package:material_ui/material_ui.dart';

After

import 'package:flutter_localizations/flutter_localizations.dart'
    show GlobalWidgetsLocalizations;
import 'package:material_ui/material_ui.dart';

Open Questions

~~I put the l10n folder in side of <material_ui or cupertino_ui>/lib/l10n because that's what the docs said. Should it be in src/?~~
- Yes, I've moved it to src/.
I put the generation scripts inside of packages/material_ui/tools/l10n. Is there a better spot? Is it ok that cupertino_ui has to use a script inside of material_ui? The reason why I didn't split the scripts in two is that there would be large amounts of code duplication.

TODOs

~~Update l10n README files.~~
Squash all of my own commits.

Resources

Fixes flutter/flutter#188757

Updating Flutter fork

…_en.arb (#29821)

…nd to make room for cupertino (#29644)

…#29708)

…e class with date time formatting (#29767)

…n the instructions (#30527)

…t of gen_localizations.dart (#29822)

Updating flutter fork

…nd generate one for cupertino english and french (#29824)

Updating flutter fork

…nguages (#31644)

…orted languages (#31644)" (#32470) This reverts commit 5c3c680.

…ted languages (#32513)

Corects a bnuch of typeos throuhgout teh Fluter codebsae. Made use of the `misspell` tool: https://github.com/client9/misspell

dart-lang/sdk#36900

* Refresh .arb files * Refresh localizations

…hese.

justinmc · 2026-07-08T21:41:22Z

I'm opening this PR to review with two caveats:

If reviewers are on board, I will squash all of my commits into one before merging, keeping all commits from flutter/flutteras-is.
I am still struggling with two test failures that strangely don't reproduce locally:

01:25 +3072 ~6: /b/s/w/ir/x/w/packages/packages/material_ui/test/l10n/date_time_test.dart: ar is initialized correctly when DateFormat is used
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: '٨:٣٠ م'
  Actual: '8:30 م'
   Which: is different.
          Expected: ٨:٣٠ م
            Actual: 8:30 م
                    ^
           Differ at offset 0

01:28 +3198 ~6 -1: /b/s/w/ir/x/w/packages/packages/material_ui/test/l10n/date_picker_test.dart: CalendarDatePicker shows dates for ar_AR
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: exactly one matching candidate
  Actual: _TextWidgetFinder:<Found 0 widgets with text "سبتمبر ٢٠١٧": []>
   Which: means none were found but one was expected

gemini-code-assist · 2026-07-08T21:53:44Z

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

justinmc · 2026-07-08T21:54:27Z

@stuartmorgan-g this and related scripts in this directory generate localization files for both material_ui and cupertino_ui. I avoided putting them in the root /scripts directory of this repo because I didn't want to pollute that with something that's specific to only 2 packages. What do you think is the better place for these scripts?

CC @QuncCccccc

If we want the script in material_ui, I think we might want it to be in material_ui/tool/ instead of material_ui/script/. See here

I avoided putting them in the root /scripts directory of this repo because I didn't want to pollute that with something that's specific to only 2 packages.

I think a new package in /script/ is fine from an organizational standpoint. Long term it might make sense to refactor it into a package with the shared parts that lives in /scritpt/, and then a tool in each package's tool/ directory that uses that shared code and has the package-specific parts, but I haven't looked at the details of the code enough to know if that would actually be viable without code duplication.

One slightly annoying thing if you go the /scritpt/ route is that we don't have a generic way that we run standard checks (analyze, format) over script/, so if we add more things there we should really fix that. That doesn't have to block landing there though; you can just add to

packages/.ci/targets/analyze.yaml

Lines 5 to 8 in 6fa759e

- name: analyze repo tools

script: .ci/scripts/analyze_repo_tools.sh

- name: analyze flutter_goldens

script: .ci/scripts/analyze_flutter_goldens.sh

and https://github.com/flutter/packages/blob/main/.ci/targets/repo_checks.yaml#L12-L19 for now and I can file an issue to make it generic (it wasn't an issue when the repo tooling was the only thing in that directory).

The problem was that I copied in a newer change (flutter/flutter#188473) when I copied in the localizations stuff. So I got the test changes from that PR, but not the code change to make the tests pass. In the future, this PR will come in when we upgrade the SDK for material_ui and cupertino_ui.

Piinks

We should make sure that we update https://flutter.dev/to/internationalization to reflect this as we prepare to ship.
So in flutter_localizations, will we deprecate the material and cupertino related bits and eventually remove?

Piinks · 2026-07-09T19:34:21Z

+   @override
+   String aboutListTileTitle(String applicationName) => 'About $applicationName';
+   ```
+   For messages with parameters, do also add the function to `GlobalCupertinoLocalizations`  in [`packages/flutter_localizations/lib/src/cupertino_localizations.dart`](https://github.com/flutter/flutter/blob/main/packages/flutter_localizations/lib/src/cupertino_localizations.dart), and add a raw getter as demonstrated below:


Should this be updated to point to cupertino_ui?

Piinks · 2026-07-09T19:35:04Z

+   Then you need to add new entries for the string to all of the other
+   language locale files by running:
+   ```
+   dart packages/material_ui/script/l10n/bin/gen_missing_localizations.dart


Just double checking, the script lives in material_ui, not cupertino_ui?

I think I answered my own question. This is a contributor facing tool, not developer, so it does not make sense to dupe it between packages, instead having it live in one place to be run out of.

Piinks · 2026-07-09T19:39:22Z

    sdk: flutter
+  flutter_localizations:
+    sdk: flutter
+  intl: any


We'll want to set this to a ^version

Piinks · 2026-07-09T19:41:27Z

+   @override
+   String aboutListTileTitle(String applicationName) => 'About $applicationName';
+   ```
+   For messages with parameters, do also add the function to `GlobalMaterialLocalizations`  in [`packages/flutter_localizations/lib/src/material_localizations.dart`](https://github.com/flutter/flutter/blob/main/packages/flutter_localizations/lib/src/material_localizations.dart), and add a raw getter as demonstrated below:


Here as well for link check

Piinks · 2026-07-09T19:42:25Z

@@ -21,17 +21,23 @@ dependencies:
    sdk: flutter
  # This is not unpinned currently.
  # See https://github.com/flutter/flutter/issues/185017
+  flutter_localizations:
+    sdk: flutter
+  intl: any


Same here re: ^version

Piinks · 2026-07-09T20:29:05Z

We should make sure that we update flutter.dev/to/internationalization to reflect this as we prepare to ship. So in flutter_localizations, will we deprecate the material and cupertino related bits and eventually remove?

Sorry, this comment posted as incomplete. Updated.

QuncCccccc

I haven't finished review. Just did a quick look. I'll do another round of review and verify the process to add new strings and export translations from translation console.

QuncCccccc · 2026-07-09T20:12:51Z

+//
+// These classes are constructed by the [getCupertinoTranslation] method at the
+// bottom of this file, and used by the [_GlobalCupertinoLocalizationsDelegate.load]
+// method defined in `cupertino_ui/lib/src/cupertino_localizations.dart`.


Suggested change

// method defined in `cupertino_ui/lib/src/cupertino_localizations.dart`.

// method defined in `cupertino_ui/lib/src/global_cupertino_localizations.dart`.

QuncCccccc · 2026-07-09T20:18:09Z

+   String get showMenuTooltip;
+   ```
+   to the localizations class `CupertinoLocalizations`,
+   in [`packages/cupertino_ui/lib/src/cupertino_localizations.dart`](https://github.com/flutter/packages/blob/main/packages/cupertino_ui/lib/src/cupertino_localizations.dart);


Suggested change

in [`packages/cupertino_ui/lib/src/cupertino_localizations.dart`](https://github.com/flutter/packages/blob/main/packages/cupertino_ui/lib/src/cupertino_localizations.dart);

in [`packages/cupertino_ui/lib/src/cupertino_localizations.dart`](https://github.com/flutter/packages/blob/main/packages/cupertino_ui/lib/src/localizations.dart);

QuncCccccc · 2026-07-09T20:20:38Z

+   @override
+   String aboutListTileTitle(String applicationName) => 'About $applicationName';
+   ```
+   For messages with parameters, do also add the function to `GlobalCupertinoLocalizations`  in [`packages/flutter_localizations/lib/src/cupertino_localizations.dart`](https://github.com/flutter/flutter/blob/main/packages/flutter_localizations/lib/src/cupertino_localizations.dart), and add a raw getter as demonstrated below:


Should this be

Suggested change

For messages with parameters, do also add the function to `GlobalCupertinoLocalizations` in [`packages/flutter_localizations/lib/src/cupertino_localizations.dart`](https://github.com/flutter/flutter/blob/main/packages/flutter_localizations/lib/src/cupertino_localizations.dart), and add a raw getter as demonstrated below:

For messages with parameters, do also add the function to `GlobalCupertinoLocalizations` in [`packages/cupertino_ui/lib/src/global_cupertino_localizations.dart`](https://github.com/flutter/packages/blob/main/packages/cupertino_ui/lib/src/global_cupertino_localizations.dart), and add a raw getter as demonstrated below:

QuncCccccc · 2026-07-09T20:22:22Z

+   until they can be translated.
+
+   Finally you need to re-generate
+   lib/src/l10n/generated_material_localizations.dart by running:


Suggested change

lib/src/l10n/generated_material_localizations.dart by running:

lib/src/l10n/generated_cupertino_localizations.dart by running:

QuncCccccc · 2026-07-09T20:24:59Z

+2. Update the .arb files. Modify the out-of-date English strings in
+   `lib/scr/l10n/cupertino_en.arb`.
+
+   You also need to re-generate `lib/src/l10n/localizations.dart` by running:


Suggested change

You also need to re-generate `lib/src/l10n/localizations.dart` by running:

You also need to re-generate `lib/src/l10n/generated_cupertino_localizations.dart` by running:

QuncCccccc · 2026-07-09T20:44:59Z

+//
+// These classes are constructed by the [getCupertinoTranslation] method at the
+// bottom of this file, and used by the [_GlobalCupertinoLocalizationsDelegate.load]
+// method defined in `flutter_localizations/lib/src/cupertino_localizations.dart`.


Suggested change

// method defined in `flutter_localizations/lib/src/cupertino_localizations.dart`.

// method defined in `cupertino_ui/lib/src/global_cupertino_localizations.dart`.

QuncCccccc · 2026-07-09T20:51:58Z

+
+import 'dart:collection';
+
+import 'package:material_ui/material_ui.dart';


The generated_material_localizations.dart shows the header should be

Suggested change

import 'package:material_ui/material_ui.dart';

import 'package:flutter/widgets.dart';

QuncCccccc · 2026-07-09T20:52:14Z

+import 'package:material_ui/material_ui.dart';
+import 'package:intl/intl.dart' as intl;
+
+import '../material_localizations.dart';


import '../global_material_localizations.dart';
import '../time.dart';
import '../typography.dart';

QuncCccccc · 2026-07-09T20:52:38Z

+import '../material_localizations.dart';
+
+// The classes defined here encode all of the translations found in the
+// `flutter_localizations/lib/src/l10n/*.arb` files.


Suggested change

// `flutter_localizations/lib/src/l10n/*.arb` files.

// `material_ui/lib/src/l10n/*.arb` files.

QuncCccccc · 2026-07-09T20:52:59Z

+//
+// These classes are constructed by the [getMaterialTranslation] method at the
+// bottom of this file, and used by the [_MaterialLocalizationsDelegate.load]
+// method defined in `flutter_localizations/lib/src/material_localizations.dart`.


Suggested change

// method defined in `flutter_localizations/lib/src/material_localizations.dart`.

// method defined in `material_ui/lib/src/global_material_localizations.dart`.

Hans Muller and others added 30 commits March 12, 2019 16:17

Update flutter_localizations translations (#29247)

02563fd

Cupertino localization step 1: add an English arb file (#29200)

b609700

Make real JSON in arb (#29463)

bbee559

Merge pull request #1 from flutter/master

e2c0b54

Updating Flutter fork

Cupertino localization step 1.5: fix a resource mismatch in cupertino…

5f691b3

…_en.arb (#29821)

Cupertino localization step 3: in-place move some material tools arou…

17f8bea

…nd to make room for cupertino (#29644)

Add needed singular resources for cupertino_en.arb (#30160)

c09baea

Cupertino localization step 5: add french arb as translated example (…

31074ba

…#29708)

Replace flutter.io with flutter.dev (#30562)

a41358a

Cupertino localization step 6: add a GlobalCupertinoLocalizations bas…

b407dc9

…e class with date time formatting (#29767)

Cupertino localization step 11: add more translation clarifications i…

0e4d73d

…n the instructions (#30527)

Cupertino localization step 7: modularize material specific things ou…

ac00c6e

…t of gen_localizations.dart (#29822)

Merge pull request flutter#2 from flutter/master

aab2495

Updating flutter fork

Cupertino localization step 8: create a gen_cupertino_localizations a…

65c4a5b

…nd generate one for cupertino english and french (#29824)

Add support for the Kazakh language (#31578)

3477c93

CupertinoPicker fidelity revision (#31464)

182f3d7

Merge pull request flutter#4 from flutter/master

d7b4c3d

Updating flutter fork

Cupertino Turkish Translation (#32013)

08a539f

Cupertino localization step 9: add tests (#29954)

91bbe82

Cupertino localization step 12: push translation for all supported la…

5c3c680

…nguages (#31644)

Revert "Cupertino localization step 12: push translation for all supp…

8a946c5

…orted languages (#31644)" (#32470) This reverts commit 5c3c680.

Merge branch 'master' into master

c3a5cc5

Cupertino localization step 12 try 2: push translation for all suppor…

da0f202

…ted languages (#32513)

Correct typos (#33322)

0783589

Corects a bnuch of typeos throuhgout teh Fluter codebsae. Made use of the `misspell` tool: https://github.com/client9/misspell

Updated localizations (#33883)

3489c61

Prepare for Uint8List SDK breaking changes (#34295)

8046e18

dart-lang/sdk#36900

Update Localizations: added 24 new locales (reprise) (#36589)

7b797fb

Add support for the Kannada (kn) locale (#37026)

2859d7e

Localization refresh (#42025)

f8bf064

* Refresh .arb files * Refresh localizations

Make sure all our .dart files have license headers (#44467)

98c9a13

github-actions Bot removed the CICD Run CI/CD label Jul 7, 2026

justinmc added the CICD Run CI/CD label Jul 7, 2026

lib/l10n to lib/src/l10n, which is the convention for packages like t…

81d634d

…hese.

github-actions Bot removed the CICD Run CI/CD label Jul 7, 2026

justinmc added the CICD Run CI/CD label Jul 7, 2026

Analyzer

abe8f5b

github-actions Bot removed the CICD Run CI/CD label Jul 8, 2026

3.44.0 uses meta 1.18.0

126e7c4

justinmc added the CICD Run CI/CD label Jul 8, 2026

Updated l10n readmes

00c4772

github-actions Bot removed the CICD Run CI/CD label Jul 8, 2026

justinmc added the CICD Run CI/CD label Jul 8, 2026

justinmc requested review from Piinks, QuncCccccc, elliette and stuartmorgan-g July 8, 2026 21:41

justinmc marked this pull request as ready for review July 8, 2026 21:42

justinmc commented Jul 8, 2026

View reviewed changes

github-actions Bot removed the CICD Run CI/CD label Jul 9, 2026

Piinks reviewed Jul 9, 2026

View reviewed changes

Formatting

ef50430

justinmc added the CICD Run CI/CD label Jul 9, 2026

Fix path for cupertino localization test

d3eaebd

github-actions Bot removed the CICD Run CI/CD label Jul 9, 2026

justinmc added the CICD Run CI/CD label Jul 9, 2026

QuncCccccc reviewed Jul 9, 2026

View reviewed changes

	- name: analyze repo tools
	script: .ci/scripts/analyze_repo_tools.sh
	- name: analyze flutter_goldens
	script: .ci/scripts/analyze_flutter_goldens.sh

	// method defined in `cupertino_ui/lib/src/cupertino_localizations.dart`.
	// method defined in `cupertino_ui/lib/src/global_cupertino_localizations.dart`.

	in [`packages/cupertino_ui/lib/src/cupertino_localizations.dart`](https://github.com/flutter/packages/blob/main/packages/cupertino_ui/lib/src/cupertino_localizations.dart);
	in [`packages/cupertino_ui/lib/src/cupertino_localizations.dart`](https://github.com/flutter/packages/blob/main/packages/cupertino_ui/lib/src/localizations.dart);

	For messages with parameters, do also add the function to `GlobalCupertinoLocalizations` in [`packages/flutter_localizations/lib/src/cupertino_localizations.dart`](https://github.com/flutter/flutter/blob/main/packages/flutter_localizations/lib/src/cupertino_localizations.dart), and add a raw getter as demonstrated below:
	For messages with parameters, do also add the function to `GlobalCupertinoLocalizations` in [`packages/cupertino_ui/lib/src/global_cupertino_localizations.dart`](https://github.com/flutter/packages/blob/main/packages/cupertino_ui/lib/src/global_cupertino_localizations.dart), and add a raw getter as demonstrated below:

	lib/src/l10n/generated_material_localizations.dart by running:
	lib/src/l10n/generated_cupertino_localizations.dart by running:

	You also need to re-generate `lib/src/l10n/localizations.dart` by running:
	You also need to re-generate `lib/src/l10n/generated_cupertino_localizations.dart` by running:

	// method defined in `flutter_localizations/lib/src/cupertino_localizations.dart`.
	// method defined in `cupertino_ui/lib/src/global_cupertino_localizations.dart`.


		import 'dart:collection';

		import 'package:material_ui/material_ui.dart';

	import 'package:material_ui/material_ui.dart';
	import 'package:flutter/widgets.dart';

	// `flutter_localizations/lib/src/l10n/*.arb` files.
	// `material_ui/lib/src/l10n/*.arb` files.

	// method defined in `flutter_localizations/lib/src/material_localizations.dart`.
	// method defined in `material_ui/lib/src/global_material_localizations.dart`.

Uh oh!

Conversation

justinmc commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How this PR was created

Before

After

Open Questions

TODOs

Resources

Uh oh!

justinmc commented Jul 8, 2026

Uh oh!

gemini-code-assist Bot commented Jul 8, 2026

Uh oh!

justinmc Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks commented Jul 9, 2026

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

justinmc commented Jul 6, 2026 •

edited

Loading

justinmc Jul 8, 2026 •

edited

Loading

Piinks left a comment •

edited

Loading