Skip to content

[video_player_android] Implement backBufferDurationMs in ExoPlayer#12124

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
sailendrabathi:video_player_android_seek
Jul 9, 2026
Merged

[video_player_android] Implement backBufferDurationMs in ExoPlayer#12124
auto-submit[bot] merged 4 commits into
flutter:mainfrom
sailendrabathi:video_player_android_seek

Conversation

@sailendrabathi

Copy link
Copy Markdown
Contributor

Adds backBufferDurationMs to video_player_android

This PR has only the android package changes from the main PR: #11810.

Following PR split as per Changing federated plugins

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for configuring ExoPlayer's back buffer duration in the Android video player by adding a backBufferDurationMs option to CreationOptions and VideoPlayerOptions. This configuration is applied to DefaultLoadControl in both PlatformViewVideoPlayer and TextureVideoPlayer. The changes also include regenerated Pigeon messaging files and new unit tests to verify the behavior. Feedback suggests explicitly validating that backBufferDurationMs is non-negative and throwing an IllegalArgumentException if an invalid negative value is provided, rather than silently ignoring it.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@stuartmorgan-g stuartmorgan-g added the triage-android Should be looked at in Android triage label Jul 7, 2026
@tarrinneal tarrinneal added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jul 8, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2026
@auto-submit

auto-submit Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12124, because - The status or check suite Linux_desktop build_all_packages stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Jul 9, 2026
@sailendrabathi

Copy link
Copy Markdown
Contributor Author

@stuartmorgan-g, regenerated messages and the tests should pass now. Please add the CI/CD label again

@stuartmorgan-g stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jul 9, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 9, 2026
@auto-submit

auto-submit Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12124, because - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Jul 9, 2026
@stuartmorgan-g stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jul 9, 2026
@auto-submit auto-submit Bot merged commit 20928d5 into flutter:main Jul 9, 2026
88 checks passed
Renzo-Olivares pushed a commit to mvincentong/flutter that referenced this pull request Jul 9, 2026
…r#189194)

flutter/packages@52d84d6...20928d5

2026-07-09 44525804+sailendrabathi@users.noreply.github.com
[video_player_android] Implement backBufferDurationMs in ExoPlayer
(flutter/packages#12124)
2026-07-09 bolling.ludwig@gmail.com [camera_platform_interface] Make
setJpegImageQuality default a no-op (flutter/packages#12123)
2026-07-09 36081049+anirudhsharma392@users.noreply.github.com
[local_auth] Clarify getAvailableBiometrics documentation regarding iOS
permissions (flutter/packages#11901)
2026-07-09 stuartmorgan@google.com [ci] Add a third web Dart unit test
shard (2/2) (flutter/packages#12150)
2026-07-08 stuartmorgan@google.com [ci] Add a third web Dart unit test
shard (1/2) (flutter/packages#12138)
2026-07-08 43054281+camsim99@users.noreply.github.com Add pre-commit
hook to verify static analysis passes & format is correct
(flutter/packages#11941)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: video_player platform-android triage-android Should be looked at in Android triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants