Skip to content

[material_ui, cupertino_ui] Migrate snippet TODOs to <callout-box>#12146

Open
dkwingsmt wants to merge 4 commits into
flutter:mainfrom
dkwingsmt:migrate-snippet
Open

[material_ui, cupertino_ui] Migrate snippet TODOs to <callout-box>#12146
dkwingsmt wants to merge 4 commits into
flutter:mainfrom
dkwingsmt:migrate-snippet

Conversation

@dkwingsmt

@dkwingsmt dkwingsmt commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Background

Dartdoc 9.0.7 added support for <callout-box> (what we used to call the blue container).

What's changed

This PR migrates all former snippet instances in API docs to <callout-box>. This is what it looks like:

image

This PR also disables unintended_html_in_doc_comment because <callout-box> is not recognized by the linter for now. An issue has been filed: dart-lang/sdk#63782

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui p: material_ui labels Jul 8, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 8, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Jul 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces placeholder TODO comments for blue example containers with <callout-box> and </callout-box> tags in the documentation comments across numerous Cupertino and Material UI files. The review feedback suggests adding an empty doc comment line (///) between consecutive closing and opening callout box tags in colors.dart, ink_decoration.dart, and list_tile.dart to ensure consistent formatting and correct markdown parsing.

Comment thread packages/material_ui/lib/src/colors.dart
Comment thread packages/material_ui/lib/src/ink_decoration.dart
Comment thread packages/material_ui/lib/src/list_tile.dart
@dkwingsmt dkwingsmt requested review from Piinks and loic-sharma July 8, 2026 17:15
@dkwingsmt dkwingsmt added the CICD Run CI/CD label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: cupertino_ui p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant