Skip to content

[local_auth] Issue 166413 ios stop authentication#12155

Open
Zubii12 wants to merge 6 commits into
flutter:mainfrom
Zubii12:issue-166413-ios-stop-authentication
Open

[local_auth] Issue 166413 ios stop authentication#12155
Zubii12 wants to merge 6 commits into
flutter:mainfrom
Zubii12:issue-166413-ios-stop-authentication

Conversation

@Zubii12

@Zubii12 Zubii12 commented Jul 9, 2026

Copy link
Copy Markdown

Add stopAuthentication implementation for ios

Fixes flutter/flutter#166413

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the stopAuthentication method for the Darwin implementation of the local_auth plugin, updating the Pigeon interface, the Dart platform interface, and the native Swift implementation to support cancelling active authentication sessions. It also includes corresponding unit tests and regenerated Pigeon and mock files. A review comment points out a potential race condition in LocalAuthPlugin.swift where activeContext is cleared unconditionally in an asynchronous callback, which could prematurely clear a newly started authentication session.

@Zubii12 Zubii12 force-pushed the issue-166413-ios-stop-authentication branch from 8e8b2fa to 33dc2b1 Compare July 9, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[local_auth] stopAuthentication method isn't work/implemented on iOS

1 participant