Fix timeout created more than once#900
Merged
Merged
Conversation
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
added
bug
Member
Author
|
Tested in my EKS clusters, fix works: 
|
stefanprodan
approved these changes
Jun 18, 2026
stefanprodan
left a comment
stefanprodan
left a comment
Member
There was a problem hiding this comment.
LGTM
Great find! thanks @matheuscscp
Member
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After pulling fluxcd/pkg#1244 in, this bug in the timeout has surfaced. We were creating two separate contexts with the
.spec.timeout, which has two problems:ctxinauth/utils.GetArtifactRegistryCredentialsis now wrapped in a closure that is called lazily, this cancellation bubbles up when the OCI client tries toAuthorize. (Authorizedoes not receive actx, which is very unfortunate fromgo-containerregistry).spec.timeoutAPI field, but up to almost twice that value.Now the timeout is applied to both auth setup + registry calls, as it should.
Note: This bug does not exist in source-controller.