ssa: Skip suspended resources from wait result errors#765
ssa: Skip suspended resources from wait result errors#765stefanprodan wants to merge 1 commit intomainfrom
Conversation
stefanprodan
added
the
area/server-side-apply
stefanprodan
force-pushed
the
wait-skip-suspended
branch
from
229a11c to
aac667d
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
wait-skip-suspended
branch
from
aac667d to
55e053d
Compare
| errs = append(errs, builder.String()) | ||
| case errors.Is(ctx.Err(), context.DeadlineExceeded) && lastStatus[id].Status != status.CurrentStatus: | ||
| var builder strings.Builder | ||
| if utils.IsSuspended(lastStatus[id].Resource) { |
There was a problem hiding this comment.
Is it safe to do this? If I have several resources deployed by a kustomization, and I want them all healthy before triggering another dependent kustomization, skipping a suspended kustomization might have unforseen consequences.
There was a problem hiding this comment.
It's debatable, if you suspend any Flux object, than all it's dependants will fail to reconcile unless you resume it, even if the object is marked as Ready=True.
|
Found some issue with this approach, since we remove the suspended resources from the result, this means |
2 participants
Fix: fluxcd/flux2#4738