[flytecopilot] Bind timeout and start-timeout flags to separate variables#7382
Draft
ddl-rliu wants to merge 1 commit into
Draft
[flytecopilot] Bind timeout and start-timeout flags to separate variables#7382ddl-rliu wants to merge 1 commit into
ddl-rliu wants to merge 1 commit into
Conversation
Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com>
ddl-rliu
force-pushed
the
rliu.timeout-bug
branch
from
d08caca to
5bd7656
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
There is a bug where if none of
--timeout, --start-timeoutare set, flytecopilot uses a timeout of 0 rather than the intended1h.What changes were proposed in this pull request?
Do not bind both flags to the same variable. Use
deprecatedStartTimeoutto store the value of the deprecatedstart-timeoutflag.How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link