Remove open_async usage in put raw data#2998
Merged
wild-endeavor merged 5 commits intomasterfrom Dec 13, 2024
Merged
Conversation
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
requested review from
Future-Outlier,
cosmicBboy,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
thomasjpfan
as code owners
git push Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario
reviewed
Dec 12, 2024
Collaborator
eapolinario
left a comment
eapolinario
left a comment
There was a problem hiding this comment.
This looks reasonable.
I don't understand the integration test failures. This change shouldn't have any impact in the minio credentials. Any idea what's going on there?
Contributor
Author
|
nope... |
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2998 +/- ##
===========================================
+ Coverage 51.08% 76.86% +25.78%
===========================================
Files 201 204 +3
Lines 21231 21406 +175
Branches 2731 2726 -5
===========================================
+ Hits 10846 16454 +5608
+ Misses 9787 4201 -5586
- Partials 598 751 +153 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario
reviewed
Dec 13, 2024
eapolinario
previously approved these changes
Dec 13, 2024
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario
approved these changes
Dec 13, 2024
wild-endeavor
added a commit
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Atharva <atharvakulkarni172003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Syntax was always wrong. This is not how open_async is used.
See fsspec/s3fs#871, which may be resolved here.
Polars
This also affected polars. In testing, noticed part of the logic was incorrect - updated and added a test to exercise.
What changes were proposed in this pull request?
Replace with a normal call - this means that writes for bytes and bytes-like objects will be blocking. Given this seems to be fundamentally missing from fsspec at this time I think it's okay.
How was this patch tested?
Unit tested and local sandbox.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link