This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Only require default plugin configuration for task types with multiple registered plugins#405
Merged
Merged
Conversation
… default plugin in config Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
EngHabu
reviewed
Feb 27, 2022
Signed-off-by: Daniel Rammer <daniel@union.ai>
EngHabu
previously approved these changes
Mar 1, 2022
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
EngHabu
approved these changes
Mar 10, 2022
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
…e registered plugins (flyteorg#405) * task types with only one registered plugin use it - otherwise declare default plugin in config Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed test and lint issues Signed-off-by: Daniel Rammer <daniel@union.ai> * updated task-config flags Signed-off-by: Daniel Rammer <daniel@union.ai> * converted to named return values Signed-off-by: Daniel Rammer <daniel@union.ai> * failing to initialize plugins on nil TaskConfig Signed-off-by: Daniel Rammer <daniel@union.ai> * updated flyteplugins version Signed-off-by: Daniel Rammer <daniel@union.ai> * updated flyteplugins to merged version Signed-off-by: Daniel Rammer <daniel@union.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
There was a corner case where the aws_batch and k8s-array plugins could not be registered simultaneously. This fixes it.
Type
Are all requirements met?
Complete description
With this change the registration of plugins for specific task types occurs such that:
(1) task types with only one registered plugin are automatically defaulted to that plugin
(2) task types with multiple registered plugins require the default-for-task-type configuration to define the default plugin
Default plugin information resident in the PluginEntry for each plugin is no longer used in determining the default plugin for a task type.
Tracking Issue
fixes flyteorg/flyte#2205
Follow-up issue
NA