-
-
Notifications
You must be signed in to change notification settings - Fork 477
Switch DB from better-sqlite3 to libsql #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
@oschwartz10612 fixed the merge conflicts. So feel free to review :) |
|
Thanks @Lokowitz! Not opposed to switching to libsql necessarily. Forgetting if we discussed this earlier... is there a way we can keep better-sqlite3 and adjust the code to not complain about the async functions or that migration would be too difficult? |
|
@oschwartz10612 Yes, there are ways to keep What I would not do, though, is delete the old migration files. In theory we can keep all versions compatible and allow a direct upgrade from e.g. 1.10 → 1.13 without forcing users through 1.12.2 first. Drizzle will happily run all missing migrations in order as long as all the That does mean a bit more work (adapting and testing the legacy migrations), but in return we don’t artificially constrain users to a specific intermediate version just because we dropped older migrations from the codebase. You can see some discussion in the following Issue #1492 |
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Hey guys,
this is related to the issue that better-sqlite3 is not supporting async anymore.
This PR is an example how we could do the step to libsql with a minimum of effort.
This will require all users to migrate first to the latest available version (current 1.12.2) because I deleted all old migration files for sql because otherwise they need to be completely rewritten.
I added a check in
server/setup/migrationsSqlite.tsto don't skip this task.If you don't want to go this way and want to rewrite all migration files, than feel free to take over because this is out of my skills :-D
Cheers Marvin