fix: prevent AI JSON parse from leaving request stuck in isWorking - #1742
Open
nothariharan wants to merge 1 commit into
Open
fix: prevent AI JSON parse from leaving request stuck in isWorking#1742nothariharan wants to merge 1 commit into
nothariharan wants to merge 1 commit into
Conversation
Wrap non-streaming AI response JSON decode in try/catch so invalid bodies keep the raw response and still clear isWorking. Fixes foss42#1741
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isWorking: truewhen response JSON decode fails (#1741).kJsonDecoder.convert/ formatting in try/catch, and keep the raw response on failure soisWorking: falsestill runs.Test plan
formattedBodyas before.Notes
sendRequestpath is heavy to scaffold); happy to add one if maintainers want it.Fixes #1741