fix: cap terminal entries at 1000 to prevent unbounded memory growth - #1743
Open
praneshnikhar wants to merge 1 commit into
Open
fix: cap terminal entries at 1000 to prevent unbounded memory growth#1743praneshnikhar wants to merge 1 commit into
praneshnikhar wants to merge 1 commit into
Conversation
The TerminalController.append method prepended new entries to the list but never removed old ones. During long sessions with streaming responses, this could accumulate thousands of entries, degrading performance and increasing memory pressure. Added a _maxEntries limit of 1000, removing excess entries from the end of the list (oldest entries) when the limit is exceeded. Fixes foss42#1648 Signed-off-by: praneshnikhar <praneshnikhar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
TerminalController.appendmethod prepended new entries to the list but never removed old ones. During long sessions with streaming responses, this could accumulate thousands of entries, degrading performance and increasing memory pressure.Added a
_maxEntrieslimit of 1000, removing excess entries from the end of the list (oldest entries) when the limit is exceeded.Fixes #1648
Change type
/kind bug