Skip to content

Initialize groundwork for PWA support #9204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tanmaykapil17 wants to merge 1 commit into from
Closed

Initialize groundwork for PWA support #9204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,10 @@ const App = Application.extend({
loadInitializers(App, config.modulePrefix);

export default App;

if ('serviceWorker' in navigator) {
window.addEventListener('load', () => {
navigator.serviceWorker.register('/service-worker.js');
Comment on lines +18 to +19
Copy link

@sourcery-ai sourcery-ai bot Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider adding basic error handling around service worker registration.

If registration fails (e.g., invalid script, wrong path, non-HTTPS), the error is currently ignored. Consider handling the returned promise (via .then/.catch or async/await) and logging/reporting failures:

window.addEventListener('load', () => {
  navigator.serviceWorker
    .register('/service-worker.js')
    .catch((err) => {
      // log or report err
    });
});

});
}