Skip to content

feat(UI): added manage group-users page #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dushimsam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(UI): added manage group-users page #248

dushimsam wants to merge 1 commit into from

Conversation

@dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Aug 9, 2022

Description

Added Manage Group Users Page.

Changes

  1. Added a new file [src/pages/Admin/Group/Manage/index.jsx]
  2. Introduced a new route in src/Routes.jsx
  3. Introduced new API callers for the UI integration.

How to test

  1. Go to the project's main directory.
  2. run command npm start
  3. Visit the page at http://localhost:PORT/admin/group/manage
  4. You will see a list of group members for the default selected group.
  5. You can change the permission of any use in that group.
manage_group_users.mp4

Related Issue

Closing #242

cc: @shaheemazmalmmd @GMishx

Shruti3004
Shruti3004 requested changes Aug 11, 2022
View reviewed changes
src/pages/Admin/Group/Manage/index.jsx Outdated
} from "services/groups";

import PropTypes from "prop-types";
import { userPermissions } from "../../../../constants/constants";
Copy link
Collaborator

@Shruti3004 Shruti3004 Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dushimsam can be imported directly

Copy link
Contributor Author

@dushimsam dushimsam Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/pages/Admin/Group/Manage/index.jsx Outdated
setShowMessage: PropTypes.func,
};

const GroupCreate = () => {
Copy link
Collaborator

@Shruti3004 Shruti3004 Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we have not created the other file for the GroupCreate function?

Copy link
Contributor Author

@dushimsam dushimsam Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/manage-group-users branch 2 times, most recently from b42eb58 to e22b654 Compare August 11, 2022 13:27
@Shruti3004
Copy link
Collaborator

Shruti3004 commented Aug 15, 2022

Changes LGTM @dushimsam. Needs testing

@Shruti3004 Shruti3004 added the needs test Needs testing label Aug 15, 2022
@dushimsam dushimsam force-pushed the dushimsam/feat/admin/manage-group-users branch from e22b654 to 429b07f Compare August 15, 2022 17:28
@dushimsam
Copy link
Contributor Author

dushimsam commented Aug 15, 2022

Alright , have added tests now.

@dushimsam dushimsam requested a review from Shruti3004 August 16, 2022 18:24
@shaheemazmalmmd
Copy link
Member

shaheemazmalmmd commented Aug 25, 2022

hello @dushimsam

While testing this branch i have encountered the below error please check.

Warning: Failed prop type: Invalid prop countof typestringsupplied toForwardRef(Pagination), expected number. Pagination@http://localhost:3000/static/js/13.chunk.js:4327:23 WithStyles@http://localhost:3000/static/js/13.chunk.js:6745:25 div div td tr tbody table div div div Browse@http://localhost:3000/static/js/20.chunk.js:926:93 div Route@http://localhost:3000/static/js/vendors~main.chunk.js:35004:29 PrivateLayout@http://localhost:3000/static/js/61.chunk.js:60:7 C@http://localhost:3000/static/js/vendors~main.chunk.js:35261:31 Switch@http://localhost:3000/static/js/vendors~main.chunk.js:35206:29 Router@http://localhost:3000/static/js/vendors~main.chunk.js:34623:30 BrowserRouter@http://localhost:3000/static/js/vendors~main.chunk.js:34244:35 Routes Fe@http://localhost:3000/static/js/vendors~main.chunk.js:42702:67 App@http://localhost:3000/static/js/main.chunk.js:111:63 GlobalProvider@http://localhost:3000/static/js/main.chunk.js:1209:7 AppWrapper Suspense index.js:1 e index.js:1 React 5 WithStyles withStyles.js:79 React 9 unstable_runWithPriority scheduler.development.js:468 React 5 Browse index.jsx:99

@shaheemazmalmmd
Copy link
Member

shaheemazmalmmd commented Aug 25, 2022

Tested Looks fine. but manage users should also have a functionality to add users to particular group. can you work on it @dushimsam

@dushimsam
Copy link
Contributor Author

dushimsam commented Aug 25, 2022

Tested Looks fine. but manage users should also have a functionality to add users to particular group. can you work on it @dushimsam

sure sir, I am going to work on it as well.

@github-actions github-actions bot added the has merge conflicts PR has merge conflicts, require rebase label Aug 25, 2022
@github-actions
Copy link

github-actions bot commented Aug 25, 2022

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/manage-group-users branch 2 times, most recently from 8f176b6 to 11a7e3e Compare September 1, 2022 05:04
@github-actions github-actions bot removed the has merge conflicts PR has merge conflicts, require rebase label Sep 1, 2022
@dushimsam dushimsam force-pushed the dushimsam/feat/admin/manage-group-users branch 2 times, most recently from 4216de9 to 99fc3ce Compare September 5, 2022 19:09
@github-actions github-actions bot added the has merge conflicts PR has merge conflicts, require rebase label Sep 5, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/manage-group-users branch from 99fc3ce to b06e0c5 Compare September 5, 2022 19:15
@github-actions github-actions bot removed the has merge conflicts PR has merge conflicts, require rebase label Sep 5, 2022
@dushimsam dushimsam force-pushed the dushimsam/feat/admin/manage-group-users branch from b06e0c5 to 698b654 Compare September 5, 2022 19:19
@dushimsam dushimsam force-pushed the dushimsam/feat/admin/manage-group-users branch from 698b654 to 9cd0e98 Compare September 6, 2022 20:44
@github-actions github-actions bot added the has merge conflicts PR has merge conflicts, require rebase label Aug 1, 2025
@github-actions
Copy link

github-actions bot commented Aug 1, 2025

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

tiyasakundu pushed a commit to tiyasakundu/FOSSologyUI that referenced this pull request Aug 28, 2025
@GMishx
Merge pull request fossology#248 from Aaditya-Singh78/doc/updates9
afd7092 
Docs(meeting notes) update documentation of week-08 meeting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shruti3004 Shruti3004 Awaiting requested review from Shruti3004

Assignees

No one assigned

Labels

has merge conflicts PR has merge conflicts, require rebase needs test Needs testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dushimsam @Shruti3004 @shaheemazmalmmd