-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(cast): derive accounts from mnemonic #12700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@zerosnacks would you mind re-triggering the failing job? I believe it failed because of an unrelated flaky test - thank you! |
|
lgtm! would you mind adding a test case for the text and json variants? |
|
PASS [ 0.240s] ( 593/1640) cast::cli wallet_derive_mnemonic_insecure
PASS [ 0.245s] ( 594/1640) cast::cli wallet_derive_mnemonic
PASS [ 0.238s] ( 595/1640) cast::cli wallet_derive_mnemonic_insecure_json
PASS [ 0.305s] ( 596/1640) cast::cli wallet_change_password
PASS [ 3.836s] ( 597/1640) cast::cli run_succeeds
PASS [ 0.242s] ( 598/1640) cast::cli wallet_derive_mnemonic_json |
zerosnacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Lgtm, CI failure unrelated
|
it seems like the CI failure for Win is a legit one, need to investigate it why happens |
I tried to rebase but CI is now failing because of another error :( |
checking, most probably related to post release support added in svm-rs and now 0.8.31 out |
Closes #12676
will produce:
[ { "address": "0x85dA99c8a7C2C95964c8EfD687E95E632Fc533D6", "private_key": "0x42b6e34dc21598a807dc19d7784c71b2a7a01f6480dc6f58258f78e539f1a1fa" }, { "address": "0x125FB391bA829e0865963D3B91711610049a9e78", "private_key": "0x0903a9a721167e2abaa0a33553cbeb209dc9300d28e4e4d6d2fac2452f93e357" }, { "address": "0x964ec59D0E05Db08440c822d7C588e63BBDE8c4e", "private_key": "0x6421222a9964cbe1b411191dcac1afda173ed99346c47302c6fe88f65d83583e" } ]